Image file writing, with test. #255
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| ) | ||
| { | ||
| // Can't use ternary operator because of differing std::shared_ptr types. | ||
| if (args.find("hgi") == args.end()) { |
There was a problem hiding this comment.
I think it would be worth explaining more why you're looking for hgi andthe differences it will do unless it is explained somewhere else ?
lanierd-adsk
approved these changes
Feb 25, 2025
ppt-adsk
added
the
ready-for-merge
lilike-adsk
deleted the
tremblp/HYDRA-1405/hydra_disk_rendering_spike
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added the capability to write a Hydra-generated image to a file, in the Flow Viewport Toolkit library.