Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Graph Container Interface #17

Merged
merged 36 commits into from
Oct 12, 2022
Merged

Graph Container Interface #17

merged 36 commits into from
Oct 12, 2022

Conversation

massimim
Copy link
Collaborator

This work introduces a new type of Container of type graph. Users can compose a graph of containers by manually setting dependencies between containers. The new abstraction also supports recursive definition: a node in a Container graph can be itself a graph.

A Graph Container supports most of the functionalities provided by a generic Container.

The PR is a single step in the goal of extending the Skeleton graph abstraction.
In following PRs the focus will be:

  • Removing unused Container types
  • Refactoring the skeleton graph to leverage the capabilities of the Container graph.

massimim added 30 commits July 14, 2022 14:11
@massimim massimim added the enhancement New feature or request label Sep 12, 2022
@massimim massimim self-assigned this Sep 12, 2022
@massimim massimim requested a review from Ahdhn September 12, 2022 18:01
@massimim massimim force-pushed the container branch 2 times, most recently from 08a3a40 to b9c587b Compare September 17, 2022 23:39
@Ahdhn
Copy link
Collaborator

Ahdhn commented Sep 27, 2022

On Windows

      Start  1: coreUt_chrono
 1/40 Test  #1: coreUt_chrono ....................   Passed   36.45 sec
      Start  2: coreUt_cli
 2/40 Test  #2: coreUt_cli .......................   Passed    0.32 sec
      Start  3: coreUt_digraph
 3/40 Test  #3: coreUt_digraph ...................   Passed    0.27 sec
      Start  4: coreUt_exceptions
 4/40 Test  #4: coreUt_exceptions ................   Passed    0.34 sec
      Start  5: coreUt_io
 5/40 Test  #5: coreUt_io ........................   Passed   30.62 sec
      Start  6: coreUt_logging
 6/40 Test  #6: coreUt_logging ...................   Passed    0.31 sec
      Start  7: coreUt_tools
 7/40 Test  #7: coreUt_tools .....................   Passed    0.29 sec
      Start  8: coreUt_tuple3d
 8/40 Test  #8: coreUt_tuple3d ...................   Passed    0.70 sec
      Start  9: sysUt_devCpu
 9/40 Test  #9: sysUt_devCpu .....................   Passed    0.40 sec
      Start 10: sysUt_devGpu
10/40 Test #10: sysUt_devGpu .....................   Passed    0.99 sec
      Start 11: sysUt_devGpuNvcc
11/40 Test #11: sysUt_devGpuNvcc .................   Passed    0.57 sec
      Start 12: sysUt_mem
12/40 Test #12: sysUt_mem ........................   Passed   19.46 sec
      Start 13: sysUt_mem3d
13/40 Test #13: sysUt_mem3d ......................   Passed    1.01 sec
      Start 14: sysUt_patterns
14/40 Test #14: sysUt_patterns ...................   Passed    3.00 sec
      Start 15: sysUt_report
15/40 Test #15: sysUt_report .....................   Passed    0.63 sec
      Start 16: setUt_gpuSet
16/40 Test #16: setUt_gpuSet .....................   Passed    0.57 sec
      Start 17: setUt_gpuSetNvcc
17/40 Test #17: setUt_gpuSetNvcc .................   Passed    0.47 sec
      Start 18: setUt_memMirrorSet
18/40 Test #18: setUt_memMirrorSet ...............   Passed    0.62 sec
      Start 19: setUt_patterns
19/40 Test #19: setUt_patterns ...................   Passed    1.87 sec
      Start 20: setUt_multiDeviceObject
20/40 Test #20: setUt_multiDeviceObject ..........   Passed    0.57 sec
      Start 21: setUt_containerGraph
21/40 Test #21: setUt_containerGraph .............   Passed    3.48 sec
      Start 22: gUt_containers
22/40 Test #22: gUt_containers ...................   Passed    0.56 sec
      Start 23: gUt_containers
23/40 Test #23: gUt_containers ...................   Passed    0.30 sec
      Start 24: gUt_dataView_patterns
24/40 Test #24: gUt_dataView_patterns ............   Passed  564.51 sec
      Start 25: gUt_map
25/40 Test #25: gUt_map ..........................   Passed    0.45 sec
      Start 26: gUt_patterns_container
26/40 Test #26: gUt_patterns_container ...........   Passed  839.85 sec
      Start 27: domainUt_swap
27/40 Test #27: domainUt_swap ....................   Passed    9.03 sec
      Start 28: gUt_tools
28/40 Test #28: gUt_tools ........................   Passed    0.50 sec
      Start 29: gUt_vtk
29/40 Test #29: gUt_vtk ..........................   Passed    0.82 sec
      Start 30: gUt_bGrid
30/40 Test #30: gUt_bGrid ........................   Passed    0.52 sec
      Start 31: sUt_skeleton
31/40 Test #31: sUt_skeleton .....................   Passed  131.43 sec
      Start 32: sUt_skeletonOnStreams
32/40 Test #32: sUt_skeletonOnStreams ............   Passed   67.21 sec
      Start 33: sUt_userInterface
33/40 Test #33: sUt_userInterface ................   Passed  132.77 sec
      Start 34: sUt_stencil
34/40 Test #34: sUt_stencil ......................   Passed    2.19 sec
      Start 35: solverUt_Poisson
35/40 Test #35: solverUt_Poisson .................   Passed    0.80 sec
      Start 36: solverPt_Poisson
36/40 Test #36: solverPt_Poisson .................   Passed    6.67 sec
      Start 37: app-fractal
37/40 Test #37: app-fractal ......................   Passed    1.21 sec
      Start 38: app-lbm
38/40 Test #38: app-lbm ..........................   Passed   33.76 sec
      Start 39: app-gameOfLife
39/40 Test #39: app-gameOfLife ...................   Passed   20.37 sec
      Start 40: app-poisson
40/40 Test #40: app-poisson ......................   Passed    4.78 sec

100% tests passed, 0 tests failed out of 40

Total Test time (real) = 1920.92 sec

@Ahdhn
Copy link
Collaborator

Ahdhn commented Oct 11, 2022

On gpu6

 Start  1: coreUt_chrono
 1/40 Test  #1: coreUt_chrono ....................   Passed   36.01 sec
      Start  2: coreUt_cli
 2/40 Test  #2: coreUt_cli .......................   Passed    0.01 sec
      Start  3: coreUt_digraph
 3/40 Test  #3: coreUt_digraph ...................   Passed    0.01 sec
      Start  4: coreUt_exceptions
 4/40 Test  #4: coreUt_exceptions ................   Passed    0.01 sec
      Start  5: coreUt_io
 5/40 Test  #5: coreUt_io ........................   Passed  100.40 sec
      Start  6: coreUt_logging
 6/40 Test  #6: coreUt_logging ...................   Passed    0.00 sec
      Start  7: coreUt_tools
 7/40 Test  #7: coreUt_tools .....................   Passed    0.00 sec
      Start  8: coreUt_tuple3d
 8/40 Test  #8: coreUt_tuple3d ...................   Passed    0.00 sec
      Start  9: sysUt_devCpu
 9/40 Test  #9: sysUt_devCpu .....................   Passed    0.22 sec
      Start 10: sysUt_devGpu
10/40 Test #10: sysUt_devGpu .....................   Passed    0.41 sec
      Start 11: sysUt_devGpuNvcc
11/40 Test #11: sysUt_devGpuNvcc .................   Passed    0.39 sec
      Start 12: sysUt_mem
12/40 Test #12: sysUt_mem ........................   Passed    0.42 sec
      Start 13: sysUt_mem3d
13/40 Test #13: sysUt_mem3d ......................   Passed    0.90 sec
      Start 14: sysUt_patterns
14/40 Test #14: sysUt_patterns ...................   Passed    1.11 sec
      Start 15: sysUt_report
15/40 Test #15: sysUt_report .....................   Passed    0.21 sec
      Start 16: setUt_gpuSet
16/40 Test #16: setUt_gpuSet .....................   Passed    0.98 sec
      Start 17: setUt_gpuSetNvcc
17/40 Test #17: setUt_gpuSetNvcc .................   Passed    0.22 sec
      Start 18: setUt_memMirrorSet
18/40 Test #18: setUt_memMirrorSet ...............   Passed    0.94 sec
      Start 19: setUt_patterns
19/40 Test #19: setUt_patterns ...................   Passed    1.02 sec
      Start 20: setUt_multiDeviceObject
20/40 Test #20: setUt_multiDeviceObject ..........   Passed    0.51 sec
      Start 21: setUt_containerGraph
21/40 Test #21: setUt_containerGraph .............   Passed    5.92 sec
      Start 22: gUt_containers
22/40 Test #22: gUt_containers ...................   Passed    1.25 sec
      Start 23: gUt_containers
23/40 Test #23: gUt_containers ...................   Passed    1.27 sec
      Start 24: gUt_dataView_patterns
24/40 Test #24: gUt_dataView_patterns ............   Passed  503.70 sec
      Start 25: gUt_map
25/40 Test #25: gUt_map ..........................   Passed    0.82 sec
      Start 26: gUt_patterns_container
26/40 Test #26: gUt_patterns_container ...........   Passed  715.75 sec
      Start 27: domainUt_swap
27/40 Test #27: domainUt_swap ....................   Passed   43.65 sec
      Start 28: gUt_tools
28/40 Test #28: gUt_tools ........................   Passed    1.11 sec
      Start 29: gUt_vtk
29/40 Test #29: gUt_vtk ..........................   Passed    1.54 sec
      Start 30: gUt_bGrid
30/40 Test #30: gUt_bGrid ........................   Passed    0.42 sec
      Start 31: sUt_skeleton
31/40 Test #31: sUt_skeleton .....................   Passed  667.81 sec
      Start 32: sUt_skeletonOnStreams
32/40 Test #32: sUt_skeletonOnStreams ............   Passed  552.12 sec
      Start 33: sUt_userInterface
33/40 Test #33: sUt_userInterface ................   Passed  312.23 sec
      Start 34: sUt_stencil
34/40 Test #34: sUt_stencil ......................   Passed    5.37 sec
      Start 35: solverUt_Poisson
35/40 Test #35: solverUt_Poisson .................   Passed    0.22 sec
      Start 36: solverPt_Poisson
36/40 Test #36: solverPt_Poisson .................   Passed    5.91 sec
      Start 37: app-fractal
37/40 Test #37: app-fractal ......................   Passed    0.81 sec
      Start 38: app-lbm
38/40 Test #38: app-lbm ..........................   Passed   28.66 sec
      Start 39: app-gameOfLife
39/40 Test #39: app-gameOfLife ...................   Passed   16.96 sec
      Start 40: app-poisson
40/40 Test #40: app-poisson ......................   Passed    4.11 sec

100% tests passed, 0 tests failed out of 40

Total Test time (real) = 3013.44 sec

@massimim massimim merged commit 8fdd96a into develop Oct 12, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Oct 12, 2022
@massimim massimim deleted the container branch October 12, 2022 13:04
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Ahdhn Ahdhn Ahdhn approved these changes

Assignees

@massimim massimim

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@massimim @Ahdhn