Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: style updates #107

Open
wants to merge 1 commit into
base: profile-updates
Choose a base branch
from
Open

Conversation

PeterMPhillips
Copy link
Member

Resolves DEV-191

@linear
Copy link

linear bot commented May 8, 2020

DEV-191 Profile tweaks

  • Update the Edit and Trash icons on the profile regions (about, work history, education history) to be the same icons that we use in the Allocations app (edit action) or Address book (trash) — but keep the colors the same as they currently are in the profiles app.

  • Deleting cover image and profile image looks like this… the title should say "Delete cover photo" and for profile it should say "Delete profile photo"

    image.png

  • [nice to have] After I sign the 3box message to authorize access, it gets stuck on this screen for a while, as it's loading the profile… is there a way to have the "Updating profile" loading state instead?

    image.png

  • This should say Update cover photo - with a lowercase c

    image.png

  • This should say Update profile photo with lowercase p

    image.png

  • The cursor:pointer property needs to be applied to the Edit and Trash icons in the Education section.

    image.png

  • All of the hyperlinks (Add more, website URL, Twitter, Add education, Add work, etc.) need to be updated to use theme.accentcolor

  • The width of the cover photo should go from edge to edge (right now there is space to the left and right, that should be 0px - need to see if this is too convoluted to implement based on the current div structure)

    image.png

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant