Better char searching and some chardata refactoring #241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OmniTroid
changed the title
|
I see that this doesn't scale the images correctly when they're bigger than standard size.. have to check that. |
ghost
closed this by deleting the head repository
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes it possible to search for a character immediately instead of waiting for all characters to load. Previously, if you wanted to play as char number 1000 in a server, you would have to wait 6ms * 1000 = 6 seconds before picking. Now you can pick it immediately. Also did some refactoring on charData and automatically focuses search box when DONE is received.
Another small change is not to remove the loading text element, but rather reuse it to show "Choose your character". This makes the layout jump around a little less.
Preview: https://webao.troid.tech/dev/better-search/