Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: Upgrade stitches to beta #47

Merged
merged 9 commits into from
Feb 17, 2021
Merged

Feature: Upgrade stitches to beta #47

merged 9 commits into from
Feb 17, 2021

Conversation

thomasdigby
Copy link
Member

@thomasdigby thomasdigby commented Feb 15, 2021 •
edited
Loading

  • Followed the migration guide to upgrade to the beta version of stitches.
  • Had to fork and publish a patch to jest-stitches to remove the global :root selector from our snapshots
  • Included @types/react as they were missing for some reason, must have been included as a dependency of another package that we removed
  • Included resize-observer-browser types to fix Radix UI type issue

https://stitches-site-git-beta.modulz-deploys.com/blog/migrating-from-alpha-to-beta

jaredLunde/jest-stitches#1

@thomasdigby thomasdigby marked this pull request as ready for review February 16, 2021 19:33
hollg
hollg reviewed Feb 17, 2021
View reviewed changes
src/stitches.ts Show resolved Hide resolved
@thomasdigby thomasdigby merged commit 7b092a5 into main Feb 17, 2021
@thomasdigby thomasdigby deleted the chore/upgrade-stitches branch February 17, 2021 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hollg hollg hollg left review comments

@andoulla andoulla andoulla approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@thomasdigby @andoulla @hollg