Even even more code cleanup

.github/workflows/build.yml

@@ -1,5 +1,5 @@
 name: build
-on: [pull_request, push]
+on: [ pull_request, push ]
 
 jobs:
   build:
@@ -8,7 +8,7 @@ jobs:
         java: [
           17,
         ]
-        os: [windows-latest]
+        os: [ windows-latest ]
     runs-on: ${{ matrix.os }}
     steps:
       - name: Checkout Repository

README.md

@@ -1,25 +1,29 @@
 # AtlasNetwork - AtlasWorld's API ⚙️
+
 Powerful 💪, Secured 🔐, Fast 🚀 and Integrated 🤝 system to manage AtlasWorld's services.
 
 ### Features
 
-- 🧩 **Module System:** AtlasNetwork works with modules, 
-                     this allows changing services or adding features to the system without requiring a rewrite of AtlasNetwork's code.
-                     AtlasNetwork works with two different modules types, Drivers and Plugins.
-  - **Drivers:** AtlasNetwork's uses abstraction for some parts of the system, 
-                 drivers implements these abstractions and makes them work with the defined service.
-                 AtlasNetwork may **require** some drivers to work properly.
-  - **Plugins:** Plugin adds features to the system, these are **optional** modules.
+- 🧩 **Module System:** AtlasNetwork works with modules,
+  this allows changing services or adding features to the system without requiring a rewrite of AtlasNetwork's code.
+  AtlasNetwork works with two different modules types, Drivers and Plugins.
+    - **Drivers:** AtlasNetwork's uses abstraction for some parts of the system,
+      drivers implements these abstractions and makes them work with the defined service.
+      AtlasNetwork may **require** some drivers to work properly.
+    - **Plugins:** Plugin adds features to the system, these are **optional** modules.
 
-- ⚙️ **Network API:** IO Socket API, for a fast and optimized data transfer. 
-                   Used to sync and notify data to AtlasWorld's services
+- ⚙️ **Network API:** IO Socket API, for a fast and optimized data transfer.
+  Used to sync and notify data to AtlasWorld's services
 - 🛡️ **No-Client-Trust:** Clients are never trusted, even if it's one of AtlasWorld's services. Security Measure
-- 🧠 **Smart Server System:** AtlasNetwork creates, deletes and stops servers to optimize resources usage on the whole network.
-- 🔗 **Private & Public HTTP API:** AtlasNetwork provides an HTTP api to access data on the network, 
-                                    Can be privately used when the environment does not offer a way to connect to AtlasNetwork's IO socket. 
+- 🧠 **Smart Server System:** AtlasNetwork creates, deletes and stops servers to optimize resources usage on the whole
+  network.
+- 🔗 **Private & Public HTTP API:** AtlasNetwork provides an HTTP api to access data on the network,
+  Can be privately used when the environment does not offer a way to connect to AtlasNetwork's IO socket.
 
 ### Module Api Usage
+
 **Add this to your build.gradle file:**
+
 ````groovy
 repositories {
     maven {
@@ -35,7 +39,9 @@ dependencies {
     compileOnly "fr.atlasworld:network-module-api:${module_api_version}"
 }
 ````
+
 **Now define your module's information here in `src/main/resource/module.json`:**
+
 ````json5
 {
   "name": "My Module", // Required
@@ -47,7 +53,9 @@ dependencies {
   "mainClass": "com.example.module.MyModule" // Required
 }
 ````
+
 **Main Class:**
+
 ````java
 package com.example.module;
 

api/src/main/java/fr/atlasworld/network/api/concurrent/action/SimpleFutureAction.java

@@ -8,9 +8,7 @@
 import java.util.ArrayList;
 import java.util.List;
 import java.util.concurrent.CountDownLatch;
-import java.util.concurrent.ExecutionException;
 import java.util.concurrent.TimeUnit;
-import java.util.concurrent.TimeoutException;
 import java.util.function.BiConsumer;
 import java.util.function.Consumer;
 import java.util.function.Function;

api/src/main/java/fr/atlasworld/network/api/networking/exception/packet/PacketExecutionException.java

@@ -13,6 +13,7 @@ public PacketExecutionException(String clientFeedback, String packetIdentifier)
     public PacketExecutionException(String message, String clientFeedback, String packetIdentifier) {
         super(message, clientFeedback, packetIdentifier);
     }
+
     public PacketExecutionException(String message, Throwable cause, String clientFeedback, String packetIdentifier) {
         super(message, cause, clientFeedback, packetIdentifier);
     }

api/src/main/java/fr/atlasworld/network/api/networking/packet/NetworkPacket.java

@@ -18,7 +18,7 @@ public interface NetworkPacket {
      * Decodes and process received requests.
      *
      * @param source source from which we received a packet.
-     * @param buffer    received buffer.
+     * @param buffer received buffer.
      */
     void decode(@NotNull ConnectionSource source, @NotNull PacketByteBuf buffer) throws PacketExecutionException;
 

api/src/main/java/fr/atlasworld/network/api/registry/RegistryObject.java

@@ -12,6 +12,7 @@ public final class RegistryObject<T> implements Supplier<T> {
 
     private final @NotNull ResourceKey valueKey;
     private @Nullable T value;
+
     private RegistryObject(@NotNull ResourceKey valueKey, @Nullable T value) {
         this.valueKey = valueKey;
         this.value = value;

build.gradle

@@ -47,11 +47,11 @@ shadowJar {
 
 tasks.withType(ProcessResources).configureEach {
     var properties = [
-            version : project_version,
-            commit : grgit.head().id,
-            branch : grgit.branch.current().name,
-            build_time : new Date().time,
-            protocol_version : protocol_version
+            version         : project_version,
+            commit          : grgit.head().id,
+            branch          : grgit.branch.current().name,
+            build_time      : new Date().time,
+            protocol_version: protocol_version
     ]
 
     inputs.properties properties

src/main/java/fr/atlasworld/network/core/module/loader/SystemGroupClassLoader.java

@@ -21,6 +21,7 @@ public class SystemGroupClassLoader extends ClassLoader implements GroupClassLoa
     private final ClassLoader rootClassLoader; // Root Class Loader
     private final Map<Module, ModuleClassLoader> moduleLoaders; // Modules Class Loaders
     private final Map<Module, List<ClassLoader>> externalLoaders; // External loaders
+
     private SystemGroupClassLoader(ClassLoader rootClassLoader) {
         this.rootClassLoader = rootClassLoader;
         this.moduleLoaders = new ConcurrentHashMap<>();

src/main/java/fr/atlasworld/network/core/networking/packet/RequestFailPacket.java

@@ -2,7 +2,6 @@
 
 import fr.atlasworld.network.api.networking.ConnectionSource;
 import fr.atlasworld.network.api.networking.exception.NetworkingException;
-import fr.atlasworld.network.api.networking.exception.packet.PacketExecutionException;
 import fr.atlasworld.network.api.networking.packet.NetworkPacket;
 import fr.atlasworld.network.api.networking.packet.PacketByteBuf;
 import fr.atlasworld.network.core.logging.LogUtils;