Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add depth limit to Component deserialization (1.20.4) #145

Merged
merged 1 commit into from
Feb 7, 2024
Merged

Add depth limit to Component deserialization (1.20.4) #145

merged 1 commit into from
Feb 7, 2024

Conversation

Focusvity
Copy link
Contributor

@Focusvity Focusvity commented Feb 5, 2024 •
edited
Loading

It's pretty much similar to the 1.20.2 patch, except we don't need to use return - it'll return as ** Invalid JSON Component ** if the depth exceeds the limit (128 by default)

Telesphoreo
Telesphoreo reviewed Feb 5, 2024
View reviewed changes
Copy link
Contributor

@Telesphoreo Telesphoreo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor formatting but I'll fix that when I get home. Looks good otherwise, thanks for patching it, I appreciate it

@Telesphoreo Telesphoreo merged commit f00572a into AtlasMediaGroup:1.20.4 Feb 7, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Telesphoreo Telesphoreo Telesphoreo approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Focusvity @Telesphoreo