Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: remove field + change avalanche-types dep #101

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 0 additions & 2 deletions crates/ash_cli/src/utils/templating.rs
Original file line number Diff line number Diff line change
Expand Up @@ -159,7 +159,6 @@ pub(crate) fn template_validator_info(

let elastic_subnet_info = &formatdoc!(
"
Connected: {}
Signer (BLS):
Public key: {}
PoP: {}
Expand All @@ -177,7 +176,6 @@ pub(crate) fn template_validator_info(
Locktime: {}
Threshold: {}
Addresses: {}",
type_colorize(&validator.connected),
type_colorize(&match validator.signer {
Some(ref signer) => format!("0x{}", hex::encode(signer.public_key.clone())),
None => String::from("None"),
Expand Down
4 changes: 2 additions & 2 deletions crates/ash_sdk/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -15,11 +15,11 @@ categories.workspace = true
keywords.workspace = true

[dependencies]
avalanche-types = { version = "0.1.2", features = [
avalanche-types = { version = "0.1.2-fix", features = [
"jsonrpc_client",
"wallet",
"subnet_evm",
] }
], git = "https://github.com/AshAvalanche/avalanche-rs.git", branch = "avalanche-types-v0.1.2-fix" }
config = { version = "0.13.3", features = ["yaml"] }
ethers = { version = "2.0.7", features = ["rustls"] }
hex = { version = "0.4.3", features = ["serde"] }
Expand Down
2 changes: 0 additions & 2 deletions crates/ash_sdk/src/avalanche/jsonrpc/platformvm.rs
Original file line number Diff line number Diff line change
Expand Up @@ -193,8 +193,6 @@ mod tests {
.find(|validator| validator.node_id == NodeId::from_str(AVAX_FUJI_NODE_ID).unwrap())
.unwrap();

// Test that the node is connected
assert!(ava_labs_node.connected);
// Test that the node has a non-zero uptime
assert!(ava_labs_node.uptime > Some(0.0));
// Test that the node has a non-zero weight
Expand Down
2 changes: 0 additions & 2 deletions crates/ash_sdk/src/avalanche/subnets.rs
Original file line number Diff line number Diff line change
Expand Up @@ -362,7 +362,6 @@ pub struct AvalancheSubnetValidator {
pub weight: Option<u64>,
#[serde(skip_serializing_if = "Option::is_none")]
pub potential_reward: Option<u64>,
pub connected: bool,
#[serde(skip_serializing_if = "Option::is_none")]
pub signer: Option<ProofOfPossession>,
#[serde(skip_serializing_if = "Option::is_none")]
Expand Down Expand Up @@ -392,7 +391,6 @@ impl AvalancheSubnetValidator {
stake_amount: validator.stake_amount,
weight: validator.weight,
potential_reward: validator.potential_reward,
connected: validator.connected,
signer: validator.signer.clone(),
uptime: validator.uptime,
validation_reward_owner: validator
Expand Down
Loading