Apply suggestions from code review

Co-authored-by: Teoh Han Hui <[email protected]>

crates/krun-server/src/bin/krun-server.rs

@@ -17,10 +17,10 @@ fn main() -> Result<()> {
 
     let server_thread = start_server(listener);
 
-    let err = Command::new(&options.command)
+    let status = Command::new(&options.command)
         .args(options.command_args)
         .status();
-    if let Err(err) = err {
+    if let Err(err) = status {
         println!("Error executing command {}: {}", options.command, err);
     }
 

crates/krun-server/src/cli_options.rs

@@ -9,9 +9,11 @@ pub struct Options {
 
 pub fn options() -> OptionParser<Options> {
     let server_port = env("KRUN_SERVER_PORT")
+        .short('p')
         .help("TCP port to listen for command launch requests")
-        .argument::<u32>("KRUN_SERVER_PORT")
-        .fallback(3333);
+        .argument("SERVER_PORT")
+        .fallback(3333)
+        .display_fallback();
     let command = positional("COMMAND");
     let command_args = any::<String, _, _>("COMMAND_ARGS", |arg| {
         (!["--help", "-h"].contains(&&*arg)).then_some(arg)

crates/utils/src/launch.rs

@@ -2,7 +2,7 @@ use std::collections::HashMap;
 
 use serde::{Deserialize, Serialize};
 
-#[derive(Debug, Serialize, Deserialize)]
+#[derive(Clone, Eq, PartialEq, Debug, Deserialize, Serialize)]
 pub struct Launch {
     pub command: String,
     pub args: Vec<String>,