-
-
Notifications
You must be signed in to change notification settings - Fork 444
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
file_manager: Added additional metadata to aid tool selection on single extruder multi-material prints #962
Changes from 3 commits
58a2bc1
c7f4bf4
ecb6191
2853912
8abc252
d9ade63
cf07e22
da73e09
18e1882
4200e0b
add4b99
d4d0d41
f997407
8eec137
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -253,7 +253,6 @@ GET /server/files/metadata?filename=tools/drill.gcode | |
|
||
/// api-response-spec | ||
open: True | ||
|
||
| Field | Type | Description | | ||
| ----------------------- | :------: | ------------------------------------------------------------ | | ||
| `size` | int | The gcode file size in bytes. | | ||
|
@@ -273,10 +272,15 @@ GET /server/files/metadata?filename=tools/drill.gcode | |
| `first_layer_extr_temp` | float | The configured first layer extruder temperature, in Celsius. | | ||
| `first_layer_bed_temp` | float | The configured first layer bed temperature, in Celsius. | | ||
| `chamber_temp` | float | The configured chamber temperature, in Celsius. | | ||
| `filament_name` | str | The name of the filament used. | | ||
| `filament_type` | str | The type of filament used, ie: `PLA`. | | ||
| `filament_name` | str | The name(s) of the filament used. | | ||
| `filament_color` | str | The colors(s) of the filament used in #RRGGBB format. | | ||
| `extruder_color` | str | The slicer defined extruder color(s) for the print. | | ||
| `filament_temp` | str | The base temperature(s) of filament used, in Celsius. | | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I noticed that this is parsed as a string. Other temperatures parsed by metadata.py are expressed as a float, is there a particuar reason for this not to be? Is it because there may be multiple? Since this is a new addition it could be returned as a list of floats. I'm open to discussion on which is best. |
||
| `filament_type` | str | The type(s) of filament used, ie: `PLA`. | | ||
| `filament_total` | float | The total length filament used in mm. | | ||
| `filament_weight_total` | float | The total weight of filament used in grams. | | ||
| `single_extruder_multi_material` | int | Identifies a multimaterial print with single extruder. | | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I wonder if we can shorten the name of this field and make it more descriptive. It seems this indicates that the print was sliced with MMU enabled, so I wonder if it would make sense to have this field be named |
||
| `referenced_tools` | string | Comma separated list of a tool numbers used in the print. | | ||
| `thumbnails` | [object] | A list of `Thumbnail Info` objects. | | ||
| | | #thumbnail-info-spec |+ | ||
| `job_id` | string? | The last `history` job ID associated with the gcode. | | ||
|
@@ -1211,4 +1215,4 @@ Not Available | |
|
||
The body of the response contains the contents of `moonraker.log`. | ||
|
||
/// | ||
/// |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For consistency with the documentation it would be preferred for these types to be
string
rather thanstr
. The docs are oriented toward JSON (JavaScript) type descriptions.