-
Notifications
You must be signed in to change notification settings - Fork 211
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update README.md #24
Update README.md #24
Conversation
Excluding the node_modules folder might be easier in some contexts.
@philiiiiiipp the reason why I was tentative about including the But given that, I'll merge this if you show me an example of when The only thing I can ever think of is that if you don't have a |
I understand your concern, but I don't think that there is a difference between exclude and include in terms of performance since webpack will apply the regex to every file/folder regardless of you using exclude or include:
Regarding the src folder, I would argue that most server side nodejs code does not have a src folder. At least it's the (somewhat standard) way that express.js will generate for you. But this is of course more of a personal preference thing. |
@@ -218,6 +218,9 @@ by an extreme amount. | |||
|
|||
`include` prevents this by specifying that this loader only applies to `.js` files in your `src` directory. | |||
|
|||
Alternative you could change `include: path.join(__dirname, 'src')` to `exclude: /node_modules/` which will then |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Replace Alternative
with Alternatively
@philiiiiiipp I guess I don't see any harm. Please just fix that one typo and I'll merge. |
Ok cool. Btw. awesome work! |
@philiiiiiipp I appreciate it. Hopefully, when I find the time, there will be a new version in gitbook format, that covers a lot more, and has helpful illustrations that I'll draw. I actually got halfway done around 2 weeks ago, but I have been short on time so it's been shelved. |
Cool stuff, I am going to have an eye out for that :-) On Wed, Apr 20, 2016 at 4:31 PM, Aria Fallah [email protected]
|
Excluding the node_modules folder might be easier in some contexts.