Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md #13

Merged
merged 2 commits into from Feb 15, 2016
Merged

Update README.md #13

merged 2 commits into from Feb 15, 2016

Conversation

ghost
Copy link

@ghost ghost commented Feb 15, 2016

This pr includes minor grammatical corrections.

This pr includes minor grammatical corrections.
@@ -81,6 +81,6 @@ For example in the diagram above I had
require('./styles.css')
```

If I include [the css-loader](https://github.com/webpack/css-loader) in my webpack config, this is not only perfectly valid, but also will actually apply the CSS to my page.
Including the [the css-loader](https://github.com/webpack/css-loader) in my webpack config is not only perfectly valid, but it will also actually apply the CSS to my page.
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This changes the meaning of the sentence. Also it says the the now.

@AriaFallah
Copy link
Owner

The first comma removal was a good catch, but your changes to the sentence about the css-loader change the meaning of the sentence. If you limit it to just that first comma, I'll merge this.

@ghost
Copy link
Author

ghost commented Feb 15, 2016

I reversed the second change. Thanks!

@AriaFallah
Copy link
Owner

Perfect thanks!

AriaFallah added a commit that referenced this pull request Feb 15, 2016
@AriaFallah AriaFallah merged commit ef992e5 into AriaFallah:master Feb 15, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant