Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

missionEditorFrame.py: Remove unimplemented AGL checkbox #1495

Merged
merged 1 commit into from
Dec 16, 2024
Merged

missionEditorFrame.py: Remove unimplemented AGL checkbox #1495

merged 1 commit into from
Dec 16, 2024

Conversation

Ryanf55
Copy link
Contributor

@Ryanf55 Ryanf55 commented Dec 15, 2024 •
edited
Loading

Closes #1265

This can be implemented at a later date.

@Ryanf55 Ryanf55 changed the title missionEditorFrame.py: Throw when unimplemented feature used missionEditorFrame.py: Throw when unimplemented AGL checkbox is used Dec 15, 2024
@Ryanf55
Copy link
Contributor Author

Ryanf55 commented Dec 15, 2024 •
edited
Loading

Thowing implementation:

Screencast.from.12-15-2024.03.21.44.PM.webm

Make it obvious that the checkbox is not implemented. Don't mislead users thinking they are in AGL when they are still in MSL.

You now get this if you click the AGL box that isn't yet connected to anything.

Traceback (most recent call last):
  File "/home/ryan/Dev/ardu_ws/src/MAVProxy/MAVProxy/modules/mavproxy_misseditor/missionEditorFrame.py", line 842, in on_agl_cb_change
    raise NotImplementedError
NotImplementedError

@peterbarker
Copy link
Contributor

Does the checkbox ever do anything? Why's it in the interface at all if it doesn't do anything?

@Ryanf55
Copy link
Contributor Author

Ryanf55 commented Dec 16, 2024 •
edited
Loading

Does the checkbox ever do anything? Why's it in the interface at all if it doesn't do anything?

No it doesn't. It wasn't hooked up (yet), but it would be a nice feature to plan in AGL.

@peterbarker
Copy link
Contributor

peterbarker commented Dec 16, 2024 via email

@Ryanf55
missionEditorFrame.py: Remove agl checkbox
cd569fa 
* It's not implemented

Signed-off-by: Ryan Friedman <[email protected]>
@Ryanf55 Ryanf55 changed the title missionEditorFrame.py: Throw when unimplemented AGL checkbox is used missionEditorFrame.py: Remove unimplemented AGL checkbox Dec 16, 2024
@Ryanf55
Copy link
Contributor Author

Ryanf55 commented Dec 16, 2024 •
edited
Loading

On Sun, 15 Dec 2024, Ryan wrote: No it doesn't. It wasn't hooked up.
.... so maybe just comment out the code which adds it to the interface?

Ok, done. Here's the UI without the button.

image

peterbarker
peterbarker approved these changes Dec 16, 2024
View reviewed changes
Copy link
Contributor

@peterbarker peterbarker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, so that seems to have been in for a decade and not worked?!

@Ryanf55
Copy link
Contributor Author

Ryanf55 commented Dec 16, 2024

OK, so that seems to have been in for a decade and not worked?!

Yep:) Just helping remove some of the footguns that other users have already reported.

@tridge tridge merged commit c18b164 into ArduPilot:master Dec 16, 2024
2 checks passed
@Ryanf55 Ryanf55 deleted the 1265-agl-checkbox branch December 16, 2024 22:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peterbarker peterbarker peterbarker approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Misseditor: AGL checkbox is unused
3 participants
@Ryanf55 @peterbarker @tridge