module submission: 2024-Jarigsma-001 #35
Conversation
…alAttachment.nlogo
Co-authored-by: Andreas Angourakis <[email protected]>
Non-compulsory fields that are empty should be deleted. Alternatively, to keep them as placeholders, they could have a null value with `null` or `~`. Making a note of this in the guide.
correcting indenting of line 12
adding compulsory field `lastUpdateDate`
docsDir and other directory or file references present in template should be deleted if not present in the current module. Making note of this in guide.
adding missing comas separating BibTex fields
start the module with v1.0.0 and mention it in CHANGELOG
Recommendations: - Code style: - adding a few extra lines of comment for pedagogic purposes - `create-edge` -> `create-preferential-attachment`, to be more specific and consistent with the algorithm terminology. - `find-preferential-partner` -> `preferential-partner,` because while verbs are good for procedures, this reporter procedure will return a partner directly, instead, for example, of setting it as a variable internally. - Refactoring: - For improving re-usability, delimiting the preferential attachment algorithm as a node-level procedure `create-preferential-attachment` (partner finding + creating link + increasing degree) instead of the global-level procedure `create-edge`. - For optimising, skipping unnecessary separation of `make-node` and `create-edge` (and the intermediary variable `new-node`) by using `create-preferential-attachment` directly inside `create-node 1 [ ... ]` (line 34) and using `other node` in `` (line 60) to ensure that the new node is not accounted as a potential partner of itself.
`number-of-nodes` -> `initial-number-nodes`
There was a problem hiding this comment.
Hi Amber,
I took the liberty of correcting the issues in NASSA.yml that were causing problems with the automatic checks. Have a look at my commits.
As the actual review, I made a few suggestions as comments and again took the liberty of directly committing edits on the .nlogo file, just to make it more re-usable. I did it because the changes were conceptually simple, but a bit hard to add only as suggestions and comments. Please let me know if you don't agree with the changes and we discard them.
I have also added Clemens Schmid as reviewer (hopefully he agrees with my suggestions!).
Anyway, if you agree with the changes I already commited, you can focus on the comments and suggestions (all are not critical issues).
Best,
Andreas
Co-authored-by: Andreas Angourakis <[email protected]>
|
Hi Andros, I have taken a look at the changes you committed directly to the .nlogo file and I do agree that they make the code more reusable. I have also made a small change to that file but only in one of the comments by the nodes-own declaration. Other than that, I have updated the readme file according to your suggestions. I hope I have managed to address all the comments and suggestions but if I have missed anything then please let me know. Otherwise, if there are further changes that should be made, let me know also. Best regards, |
Adding Barabási's references to .bib file
No description provided.