Bugfix/bulk import #205
Closed
Bugfix/bulk import #205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…licationFactor and writeConcern as option parameters as well
…by the server automatically
…ion-example Add JSON Schema validation example.
Added support for satellite graphs
…mple_typo Fix typo in example.
Fix social example Fix social example
change "validation" attribute name to "schema" after the corresponding API changed during the ArangoDB 3.7 alpha phase.
change "validation" attribute name to "schema"
Fix social example
…-arango-testing-integration add simple driver test wrapper script
…gelog-typos fix some typos in CHANGELOG.rst
…me-typos fix small typos in readme
Allow to easily check if an id exist or not. Especially when working with edge and need an easy way to check _from, _to field
…contains Add __contains__ method to allow to easily check if an id reference a valid document
|
Not sure why this pulled in all of those commits, let me fix that, sorry! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #188 and #203
For some reason it seems like the bulkImport methods were expecting the data being POSTed to be altered... the requests library doesn't do that. Since this entirely broke the error checking and thus the methods altogether, I replaced it with a simple status_code check. 201 is successful per the docs, so if it isn't 201, raise an UpdateError with the response data.