Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tweaks: Fix "Caught-up line" not appearing on mobile devices #1427

Merged

Conversation

marcustyphoon
Copy link
Collaborator

Description

As per the linked issue, this fixes an issue where the ≤540px-width mobile layout caused the line indicator created by the Turn the Changes/Shop/etc. links carousel into a separating line tweak not to appear. This is due to the Tumblr frontend hiding timeline elements with less than a certain height value, and that value not changing with the reduced spacing when the layout changes.

This adds 2px of spacing above and below the line in this layout to fix this. (3px is the total required, but that wouldn't be symmetrical.)

Resolves #1398.

Testing steps

  • Open your dash with a viewport width of <540px (zooming in makes this easier on a desktop browser).
  • Confirm that the affected tweak works and the visual spacing above and below the line indicator appears symmetrical.

@marcustyphoon marcustyphoon added the bugfix Restores intended behavior label Mar 29, 2024
@marcustyphoon marcustyphoon merged commit 1aaa65a into AprilSylph:master Apr 2, 2024
2 checks passed
@marcustyphoon marcustyphoon deleted the caught-up-line-mobile branch April 2, 2024 23:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix Restores intended behavior
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tweaks: "Caught-up line" doesn't appear on mobile devices
2 participants