Tweaks: Fix carousel hiding affecting "your tags" tab #1426
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This prevents the caught up line tweak (officially
Turn the Changes/Shop/etc. links carousel into a separating line) from affecting the carousel atop the "your tags" tab at https://www.tumblr.com/dashboard/hubs.Specifying the dashboard in question seemed like the easiest way to do this, as there is very little that differentiates the carousel we want to hide from a followed tags carousel. They mostly seem to use the same rendering code; the API response that makes the thing we want to hide (I still call it the "you're caught up" carousel) has
objectType: "followed_tag_carousel_card".Resolves #1375.
Testing steps