Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show Originals: Add option to hide only reblogs you follow #1422

Merged

Conversation

marcustyphoon
Copy link
Collaborator

Description

As per the linked issue, this adds an option to Show Originals that shows reblogs if you don't follow the account that's being reblogged. This makes it into a "my friends all reblog each other and I don't really need to see the same content a bunch of times" filter.

Tried it out myself and I can definitely see the appeal, though my dash is mostly people who don't know each other and so most of the content is new to me.

Resolves #1386.

Testing steps

If desired, unrevert the test commit, enable Show Originals and both "always show reblogs" options, go to the "all posts" tab, and observe that reblogs that you wouldn't expect to see on your dash twice are highlighted green, while self reblogs and reblogs of other users you follow are highlighted red.

@marcustyphoon marcustyphoon force-pushed the show-originals-not-following branch from bffbbc7 to 7223a5a Compare March 25, 2024 07:31
@AprilSylph AprilSylph self-requested a review April 29, 2024 07:45
Copy link
Owner

@AprilSylph AprilSylph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

otherwise LGTM

src/scripts/show_originals.json Outdated Show resolved Hide resolved
Copy link
Owner

@AprilSylph AprilSylph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oops, wrong radio button ^_^;

Copy link
Owner

@AprilSylph AprilSylph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yay

(up to you whether to follow the alternative wording suggestion in #1422 (comment))

@marcustyphoon
Copy link
Collaborator Author

Hmmmmm I could definitely go either way. Trying that out in the context with its fellow checkboxes, I think the currently slightly funny wording is a bit clearer.

@marcustyphoon marcustyphoon merged commit 5d5c945 into AprilSylph:master Apr 29, 2024
2 checks passed
@marcustyphoon marcustyphoon deleted the show-originals-not-following branch April 29, 2024 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Option to only show reblogs of accounts I'm not following
2 participants