Quote Replies: Fix functionality on "Tumblr Patio" preview

[marcustyphoon]

Description

This fixes the selection of notification elements used in Quote Replies so that it's a) consistent with NotificationBlock, and b) works on activity columns in the "Tumblr Patio" feature preview.

Resolves #1368.

It also fixes an error that would appear in the js console when you opened this menu with NotificationBlock enabled, as it erroneously selected an element in that menu:

This relies a lot on aria-role.

Testing steps

• Confirm that Quote Replies and NotificationBlock work on an activity column in Tumblr Patio, in the activity modal, and on the activity page.

[AprilSylph]

No apparent regressions. Can't test on Patio; don't have it! I'll trust you to test the PR build again before merging.

(I could technically test XKit changes on my Tumblr admin account... but IDK if that counts as conflict-of-interest or not 😋)

[nightpool]

I can test on Patio if you want

…

On Tue, Feb 20, 2024, 5:00 PM April Sylph ***@***.***> wrote: ***@***.**** approved this pull request. No apparent regressions. Can't test on Patio; don't have it! I'll trust you to test the PR build again before merging. (I could technically test XKit changes on my Tumblr admin account... but IDK if that counts as conflict-of-interest or not 😋) — Reply to this email directly, view it on GitHub <#1373 (review)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AABZCVZKARDIG2QNNIQZL4DYUUTIDAVCNFSM6AAAAABCBFSBHWVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTQOJRG42DGOBTGM> . You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>

[AprilSylph]

@nightpool yay ❤️

[marcustyphoon]

No apparent regressions. Can't test on Patio; don't have it!

Wait, do you not get your personal account automatically dogfooded into this kind of thing?

[AprilSylph]

Nope! I decided to make a new account for work-related stuff. That account gets all the staff privileges, while my personal and testing accounts don't. Whitelisting them for new features is as manual a process as whitelisting other XKit devs.

[marcustyphoon]

Makes sense! Although, I mean, your testing account is the testing account of an XKit dev... :D

Oh, wait, I guess it probably doesn't have ad-free, does it. That makes this particular case more complicated. (And I guess that I'm happy my personal account does have Patio, whether that's intentional or lucky.)

[marcustyphoon]

I have tested this again and it continues to work as expected, including on Patio.

[marcustyphoon]

Treating my own testing as an approval re: patio testing.