Open in Tabs: Fix interaction with Tumblr Patio UI #1372
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AprilSylph
requested changes
Feb 20, 2024
There was a problem hiding this comment.
- Type a blog name (e.g.
pyoro) into the site's search bar - Click any of the blog results that have avatars (i.e. are not the "Go to @{blogName}" result)
- Production result: The blog is opened in a new tab
- PR result: The blog is opened in the blog view
Can the exclusion selector be made more specific to Patio?
|
Ah, shoot. Let me check. |
|
Indeed it can be. This is why we have review, people! |
|
Re-performed testing myself; seems to work as expected. |
|
@AprilSylph This being a oneliner (basically), may I request a merge-without-formal-review and version release? |
AprilSylph
approved these changes
Mar 11, 2024
|
I was about to regression-test this anyway, so I did. Will do a release once this is merged (if that's what you're asking for), although it's late for me so that will likely end up being tomorrow. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Prevents Open in Tabs from intercepting a click in part of the "Tumblr Patio" feature preview UI that's used to add a blog column.
Resolves #1371.
Testing steps