No Recommended: Reliably select blog carousels via react props #1348
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Enough classname targeting.
This uses our
timelineObject
utility to read the react internal data of recommendation carousels, reliably identifying those which are blog recommendations (as opposed to tag recommendations). This is, of course, fragile to changes in the underlying API data, but it seems better than trying to target a classname,since there aren't any unique "blog recommendation"y ones in this element.Resolves #1346.
Testing steps