Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No Recommended: Change blog and tag carousel selectors #1341

Merged
merged 1 commit into from
Dec 3, 2023
Merged

No Recommended: Change blog and tag carousel selectors #1341

merged 1 commit into from
Dec 3, 2023

Conversation

enchanted-sword
Copy link
Contributor

Description

Fixes #1335 by changing the blog carousel and tag card selectors to match the current element classes

const blogCarouselSelector = `${listTimelineObjectSelector} ${keyToCss('blogRecommendation')}`;
const tagCardSelector = keyToCss('tagCard');

Testing steps

  • Enable the No Recommended feature and the two related preferences
  • Scroll through the timeline

@marcustyphoon
Copy link
Collaborator

I wonder if we could just do like [data-cell-id^="timelineObject:carousel"]. Whether that's more or less robust is just complete guesswork, though.

@enchanted-sword
Copy link
Contributor Author

I wonder if we could just do like [data-cell-id^="timelineObject:carousel"]. Whether that's more or less robust is just complete guesswork, though.

I thought about that initially, but the same id scheme is used for both blog and tag carousels, so that doesn't work if they're separate preferences.

@AprilSylph AprilSylph merged commit d9b4cf6 into AprilSylph:master Dec 3, 2023
2 checks passed
@enchanted-sword enchanted-sword deleted the timeline-carousel-fix branch December 5, 2023 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No Recommended not hiding recommended tags
3 participants