-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removed the next pointer offset condition to set data size #328
base: main
Are you sure you want to change the base?
Conversation
Test Results Linux_ARM64 1 files ±0 1 suites ±0 10m 42s ⏱️ -1s For more details on these failures, see this check. Results for commit f52055d. ± Comparison against base commit 110a2e2. ♻️ This comment has been updated with latest results. |
Test Results Linux 1 files ±0 1 suites ±0 10m 12s ⏱️ ±0s For more details on these failures, see this check. Results for commit 2867824. ± Comparison against base commit 53157e2. ♻️ This comment has been updated with latest results. |
Test Results Linux-CudaT 1 files ±0 1 suites ±0 10m 29s ⏱️ -1s For more details on these failures, see this check. Results for commit d488909. ± Comparison against base commit ba0f2ff. ♻️ This comment has been updated with latest results. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job!
IMPORTANT: All PRs must be linked to an issue (except for extremely trivial and straightforward changes).
Description
Fixed the issue of data size not getting set for the 2nd time due to nextPtrOffset (condition where we were checking if the value is same is declared value) variable getting initialized while setting data size for the first time.
Alternative(s) considered
Have you considered any alternatives? And if so, why have you chosen the approach in this PR?
Type
Type Choose one: (Bug fix)
Screenshots (if applicable)
Checklist