Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sqlite backend #107

Merged
merged 26 commits into from
Mar 19, 2024
Merged

sqlite backend #107

merged 26 commits into from
Mar 19, 2024

Conversation

prabhu
Copy link
Contributor

@prabhu prabhu commented Mar 17, 2024

Rewritten to use sqlite backend with CVE 5.0 schema and vers.

Fixes #104
Fixes #83
Part support for #91

cc: @heubeck @saketjajoo could you kindly help test this with some purls?

Signed-off-by: Prabhu Subramanian <[email protected]>

Store to sqlite

Signed-off-by: Prabhu Subramanian <[email protected]>
@prabhu prabhu requested a review from cerrussell March 17, 2024 21:11
Signed-off-by: Prabhu Subramanian <[email protected]>
@prabhu prabhu added enhancement New feature or request Ready for QA labels Mar 17, 2024
prabhu added 4 commits March 17, 2024 22:04
Signed-off-by: Prabhu Subramanian <[email protected]>
Signed-off-by: Prabhu Subramanian <[email protected]>
Signed-off-by: Prabhu Subramanian <[email protected]>
Signed-off-by: Prabhu Subramanian <[email protected]>
@saketjajoo
Copy link

@prabhu Am I searching incorrectly?

Screenshot 2024-03-17 at 21 45 44

@prabhu
Copy link
Contributor Author

prabhu commented Mar 18, 2024

@prabhu Am I searching incorrectly?

Screenshot 2024-03-17 at 21 45 44

It's a good test but for depscan. Vdb doesn't do aliasing so best to open the index db with a sqlite browser and use that data for searching. Or search by CVE

@prabhu
Copy link
Contributor Author

prabhu commented Mar 18, 2024

@cerrussell @saketjajoo Please update and try with the latest commit that uses apsw instead of sqlite3. This should result in even smaller dbs with improved performance.

Signed-off-by: Prabhu Subramanian <[email protected]>
Copy link
Member

@cerrussell cerrussell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only a few minor changes. Love being able to explore the db!

vdb/cli.py Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
vdb/lib/db6.py Show resolved Hide resolved
pyproject.toml Show resolved Hide resolved
prabhu added 8 commits March 19, 2024 08:58
Signed-off-by: Prabhu Subramanian <[email protected]>
Signed-off-by: Prabhu Subramanian <[email protected]>
Signed-off-by: Prabhu Subramanian <[email protected]>
Signed-off-by: Prabhu Subramanian <[email protected]>
Signed-off-by: Prabhu Subramanian <[email protected]>
Signed-off-by: Prabhu Subramanian <[email protected]>
Signed-off-by: Prabhu Subramanian <[email protected]>
prabhu added 5 commits March 19, 2024 17:02
Signed-off-by: Prabhu Subramanian <[email protected]>
Signed-off-by: Prabhu Subramanian <[email protected]>
Signed-off-by: Prabhu Subramanian <[email protected]>
@cerrussell
Copy link
Member

@prabhu The counts for the data vs index no longer match.

@prabhu
Copy link
Contributor Author

prabhu commented Mar 19, 2024

@prabhu The counts for the data vs index no longer match.

Yes, this is fine. The index is only to know whether there is at least 1 matching CVE.

Signed-off-by: Prabhu Subramanian <[email protected]>
@prabhu prabhu merged commit 4950a83 into master Mar 19, 2024
12 checks passed
@prabhu prabhu deleted the feature/store5 branch March 19, 2024 22:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Ready for QA
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[v6] investigate sqlite3 db [v6] Format for vulnerability database
3 participants