Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trigger appimagetool build #50

Closed
wants to merge 5 commits into from
Closed

Trigger appimagetool build #50

wants to merge 5 commits into from

Conversation

probonopd
Copy link
Member

@probonopd probonopd commented Aug 5, 2024

Try to trigger an appimagetool build in addition to uploading the continuous build to GitHub Releases.

Thus, when a change in this repository prevents the appimagetool AppImage from being built correctly, we will know immediately rather than a few months down the line.

This in part might have prevented

from having happened unnoticed.

Try to trigger an appimagetool build
@AppImage AppImage deleted a comment from github-actions bot Aug 5, 2024
@AppImage AppImage deleted a comment from github-actions bot Aug 5, 2024
@AppImage AppImage deleted a comment from github-actions bot Aug 5, 2024
@AppImage AppImage deleted a comment from github-actions bot Aug 5, 2024
@probonopd
Copy link
Member Author

TypeError: Cannot read properties of undefined (reading 'token')

How to do this correctly?

@TheAssassin
Copy link
Member

We've talked about this recently and I absolutely hate the idea. Plus, the token you try to use isn't even authorized to do so.

appimagetool automatically downloads the latest runtime anyway.

@TheAssassin TheAssassin closed this Aug 5, 2024
@TheAssassin
Copy link
Member

P.S.: If testing is your intention, you can clone appimagetool's repository here, too, and run the build script accordingly.

@TheAssassin TheAssassin deleted the probonopd-patch-1 branch August 5, 2024 18:15
@probonopd
Copy link
Member Author

We've talked about this recently and I absolutely hate the idea.

Can you remind me of why you don't like this? Maybe combining the repos of type2-runtime and appimagetool would be a more elegant solution then?

appimagetool automatically downloads the latest runtime anyway.

Which is what I still think is too fragile, especially when the two are not in sync (which can happen due to developer error or simply because the user uses an older appimagetool version...)

@TheAssassin
Copy link
Member

Maybe combining the repos of type2-runtime and appimagetool would be a more elegant solution then?

Yet again, discussed and rejected. That's what we had, and it's what we never want to go back to.

@TheAssassin
Copy link
Member

You should open an issue by the way.

@probonopd
Copy link
Member Author

probonopd commented Aug 5, 2024

You should open an issue by the way.

Open an issue for what? Everything I propose doesn't seem to be liked by you (triggering builds in another repo automatically, merging repos). For bundling the runtime in the linuxdeployqt AppImage there is already an issue open,

@TheAssassin
Copy link
Member

The issue here is that this discussion is likely going to be lost in a closed PR.

Everything I propose doesn't seem to be liked by you

We've discussed every single option and I've always had the better arguments after all. It's tiring to reiterate over each of them every time some issue surfaces. It's nothing I'd do in a project because it's not productive.

It seems that the issue here is missing documentation from meetings we had...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants