Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix detection of usable CA certificate bundle #45

Merged
merged 4 commits into from
May 5, 2024
Merged

Fix detection of usable CA certificate bundle #45

merged 4 commits into from
May 5, 2024

Conversation

TheAssassin
Copy link
Member

@TheAssassin TheAssassin commented May 5, 2024 •
edited
Loading

Fixes segfaults in #34.

Also pins Alpine Docker image version to fix build issues due to the previous use of the bleeding edge tag.

@TheAssassin TheAssassin force-pushed the fix-nullptr branch 2 times, most recently from e7c0ca0 to b8883c9 Compare May 5, 2024 16:42
@probonopd
Copy link
Member

On FreeBSD, we now get

VirtualBox% unzip appimagetool-x86_64.build.zip                     
Archive:  appimagetool-x86_64.build.zip
 extracting: appimagetool-x86_64.AppImage  
VirtualBox% chmod +x appimagetool-x86_64.AppImage                   
VirtualBox% ./appimagetool-x86_64.AppImage --appimage-extract       
VirtualBox% ./appimagetool-x86_64.AppImage ./squashfs-root --verbose
appimagetool, continuous build (git version c128ed4), build 106 built on 2024-05-05 16:03:35 UTC
WARNING: zsyncmake command is missing, please install it if you want to use binary delta updates
WARNING: appstreamcli command is missing, please install it if you want to use AppStream metadata
Desktop file: /home/liveuser/Downloads/squashfs-root/appimagetool.desktop
Name: appimagetool
Icon: appimagetool
Exec: appimagetool
Comment: Tool to generate AppImages from AppDirs
Type: Application
Categories: Development;
/home/liveuser/Downloads/squashfs-root/usr/bin/mksquashfs used for determining architecture x86_64
/home/liveuser/Downloads/squashfs-root/usr/bin/appimagetool used for determining architecture x86_64
Using architecture x86_64
Using app name extracted from desktop file: appimagetool
/home/liveuser/Downloads/squashfs-root should be packaged as appimagetool-x86_64.AppImage
AppStream upstream metadata found in usr/share/metainfo/appimagetool.appdata.xml
Generating squashfs...
Downloading runtime file from https://github.com/AppImage/type2-runtime/releases/download/continuous/runtime-x86_64
libcurl's default CA certificate bundle file /etc/ssl/certs/ca-certificates.crt was not found on this system, nulling
libcurl's default CA certificate bundle directory /etc/ssl/certs was found on this system
* Host github.com:443 was resolved.
* IPv6: (none)
* IPv4: 140.82.121.3
*   Trying 140.82.121.3:443...
* Connected to github.com (140.82.121.3) port 443
* ALPN: curl offers h2,http/1.1
* error setting certificate file: 
* error setting certificate file: 
* Closing connection
* error setting certificate file: 
* error setting certificate file: 
Downloaded runtime binary of size -1
Failed to download runtime file, please download the runtime manually fromhttps://github.com/AppImage/type2-runtime/releases and pass it to appimagetool with--runtime-file
VirtualBox% ls -lh /etc/ssl/certs/ca-certificates.crt
ls: /etc/ssl/certs/ca-certificates.crt: No such file or directory
VirtualBox% ls -lh /etc/ssl/certs
total 0
lrwxr-xr-x  1 root wheel   56B May  5 15:45 002c0b4f.0 -> ../../../usr/share/certs/trusted/GlobalSign_Root_R46.pem
lrwxr-xr-x  1 root wheel   57B May  5 15:45 0179095f.0 -> ../../../usr/share/certs/trusted/BJCA_Global_Root_CA1.pem
lrwxr-xr-x  1 root wheel   78B May  5 15:45 02265526.0 -> ../../../usr/share/certs/trusted/Entrust_Root_Certification_Authority_-_G2.pem
lrwxr-xr-x  1 root wheel   60B May  5 15:45 062cdee6.0 -> ../../../usr/share/certs/trusted/GlobalSign_Root_CA_-_R3.pem
lrwxr-xr-x  1 root wheel   58B May  5 15:45 064e0aa9.0 -> ../../../usr/share/certs/trusted/QuoVadis_Root_CA_2_G3.pem
lrwxr-xr-x  1 root wheel   83B May  5 15:45 06dc52d5.0 -> ../../../usr/share/certs/trusted/SSL_com_EV_Root_Certification_Authority_RSA_R2.pem
lrwxr-xr-x  1 root wheel   67B May  5 15:45 08063a00.0 -> ../../../usr/share/certs/trusted/Security_Communication_RootCA3.pem
lrwxr-xr-x  1 root wheel   87B May  5 15:45 09789157.0 -> ../../../usr/share/certs/trusted/Starfield_Services_Root_Certificate_Authority_-_G2.pem
lrwxr-xr-x  1 root wheel   48B May  5 15:45 0a775a30.0 -> ../../../usr/share/certs/trusted/GTS_Root_R3.pem
lrwxr-xr-x  1 root wheel   49B May  5 15:45 0b1b94ef.0 -> ../../../usr/share/certs/trusted/CFCA_EV_ROOT.pem
lrwxr-xr-x  1 root wheel   49B May  5 15:45 0b9bc432.0 -> ../../../usr/share/certs/trusted/ISRG_Root_X2.pem
lrwxr-xr-x  1 root wheel   77B May  5 15:45 0bf05006.0 -> ../../../usr/share/certs/trusted/SSL_com_Root_Certification_Authority_ECC.pem
lrwxr-xr-x  1 root wheel   65B May  5 15:45 0f5dc4f3.0 -> ../../../usr/share/certs/trusted/UCA_Extended_Validation_Root.pem
lrwxr-xr-x  1 root wheel   59B May  5 15:45 0f6fa695.0 -> ../../../usr/share/certs/trusted/GDCA_TrustAUTH_R5_ROOT.pem
lrwxr-xr-x  1 root wheel   48B May  5 15:45 1001acf7.0 -> ../../../usr/share/certs/trusted/GTS_Root_R1.pem
lrwxr-xr-x  1 root wheel   79B May  5 15:45 106f3e4d.0 -> ../../../usr/share/certs/trusted/Entrust_Root_Certification_Authority_-_EC1.pem
lrwxr-xr-x  1 root wheel   60B May  5 15:45 14bc7599.0 -> ../../../usr/share/certs/trusted/emSign_ECC_Root_CA_-_G3.pem
lrwxr-xr-x  1 root wheel   56B May  5 15:45 18856ac4.0 -> ../../../usr/share/certs/trusted/SecureSign_RootCA11.pem
lrwxr-xr-x  1 root wheel   64B May  5 15:45 1d3472b9.0 -> ../../../usr/share/certs/trusted/GlobalSign_ECC_Root_CA_-_R5.pem
lrwxr-xr-x  1 root wheel   70B May  5 15:45 1e08bfd1.0 -> ../../../usr/share/certs/trusted/IdenTrust_Public_Sector_Root_CA_1.pem
lrwxr-xr-x  1 root wheel   65B May  5 15:45 1e09d511.0 -> ../../../usr/share/certs/trusted/T-TeleSec_GlobalRoot_Class_2.pem
lrwxr-xr-x  1 root wheel   71B May  5 15:45 244b5494.0 -> ../../../usr/share/certs/trusted/DigiCert_High_Assurance_EV_Root_CA.pem
lrwxr-xr-x  1 root wheel   56B May  5 15:45 2923b3f9.0 -> ../../../usr/share/certs/trusted/emSign_Root_CA_-_G1.pem
lrwxr-xr-x  1 root wheel   53B May  5 15:45 2ae6433e.0 -> ../../../usr/share/certs/trusted/CA_Disig_Root_R2.pem
lrwxr-xr-x  1 root wheel   59B May  5 15:45 2b349938.0 -> ../../../usr/share/certs/trusted/AffirmTrust_Commercial.pem
lrwxr-xr-x  1 root wheel   92B May  5 15:45 32888f65.0 -> ../../../usr/share/certs/trusted/Hellenic_Academic_and_Research_Institutions_RootCA_2015.pem
lrwxr-xr-x  1 root wheel   60B May  5 15:45 3513523f.0 -> ../../../usr/share/certs/trusted/DigiCert_Global_Root_CA.pem
lrwxr-xr-x  1 root wheel   94B May  5 15:45 3bde41ac.0 -> ../../../usr/share/certs/trusted/Autoridad_de_Certificacion_Firmaprofesional_CIF_A62634068.pem
lrwxr-xr-x  1 root wheel   57B May  5 15:45 3e359ba6.0 -> ../../../usr/share/certs/trusted/BJCA_Global_Root_CA2.pem
lrwxr-xr-x  1 root wheel   78B May  5 15:45 3fb36b73.0 -> ../../../usr/share/certs/trusted/NAVER_Global_Root_Certification_Authority.pem
lrwxr-xr-x  1 root wheel   64B May  5 15:45 40193066.0 -> ../../../usr/share/certs/trusted/Certum_Trusted_Network_CA_2.pem
lrwxr-xr-x  1 root wheel   49B May  5 15:45 4042bcee.0 -> ../../../usr/share/certs/trusted/ISRG_Root_X1.pem
lrwxr-xr-x  1 root wheel   67B May  5 15:45 40547a79.0 -> ../../../usr/share/certs/trusted/COMODO_Certification_Authority.pem
lrwxr-xr-x  1 root wheel   56B May  5 15:45 406c9bb1.0 -> ../../../usr/share/certs/trusted/emSign_Root_CA_-_C1.pem
lrwxr-xr-x  1 root wheel   62B May  5 15:45 48bec511.0 -> ../../../usr/share/certs/trusted/Certum_Trusted_Network_CA.pem
lrwxr-xr-x  1 root wheel   60B May  5 15:45 4b718d9b.0 -> ../../../usr/share/certs/trusted/emSign_ECC_Root_CA_-_C3.pem
lrwxr-xr-x  1 root wheel   78B May  5 15:45 4bfab552.0 -> ../../../usr/share/certs/trusted/Starfield_Root_Certificate_Authority_-_G2.pem
lrwxr-xr-x  1 root wheel   59B May  5 15:45 4f316efb.0 -> ../../../usr/share/certs/trusted/SwissSign_Gold_CA_-_G2.pem
lrwxr-xr-x  1 root wheel   65B May  5 15:45 5443e9e3.0 -> ../../../usr/share/certs/trusted/T-TeleSec_GlobalRoot_Class_3.pem
lrwxr-xr-x  1 root wheel   60B May  5 15:45 54657681.0 -> ../../../usr/share/certs/trusted/Buypass_Class_2_Root_CA.pem
lrwxr-xr-x  1 root wheel   61B May  5 15:45 57bcb2da.0 -> ../../../usr/share/certs/trusted/SwissSign_Silver_CA_-_G2.pem
lrwxr-xr-x  1 root wheel   71B May  5 15:45 5860aaa6.0 -> ../../../usr/share/certs/trusted/Security_Communication_ECC_RootCA1.pem
lrwxr-xr-x  1 root wheel   62B May  5 15:45 5931b5bc.0 -> ../../../usr/share/certs/trusted/D-TRUST_EV_Root_CA_1_2020.pem
lrwxr-xr-x  1 root wheel   55B May  5 15:45 5ad8a5d6.0 -> ../../../usr/share/certs/trusted/GlobalSign_Root_CA.pem
lrwxr-xr-x  1 root wheel   59B May  5 15:45 5cd81ad7.0 -> ../../../usr/share/certs/trusted/TeliaSonera_Root_CA_v1.pem
lrwxr-xr-x  1 root wheel   78B May  5 15:45 5e98733a.0 -> ../../../usr/share/certs/trusted/Entrust_Root_Certification_Authority_-_G4.pem
lrwxr-xr-x  1 root wheel   56B May  5 15:45 5f15c80c.0 -> ../../../usr/share/certs/trusted/TWCA_Global_Root_CA.pem
lrwxr-xr-x  1 root wheel   56B May  5 15:45 5f618aec.0 -> ../../../usr/share/certs/trusted/certSIGN_Root_CA_G2.pem
lrwxr-xr-x  1 root wheel   60B May  5 15:45 607986c7.0 -> ../../../usr/share/certs/trusted/DigiCert_Global_Root_G2.pem
lrwxr-xr-x  1 root wheel   48B May  5 15:45 626dceaf.0 -> ../../../usr/share/certs/trusted/GTS_Root_R2.pem
lrwxr-xr-x  1 root wheel   62B May  5 15:45 653b494a.0 -> ../../../usr/share/certs/trusted/Baltimore_CyberTrust_Root.pem
lrwxr-xr-x  1 root wheel   60B May  5 15:45 68dd7389.0 -> ../../../usr/share/certs/trusted/Hongkong_Post_Root_CA_3.pem
lrwxr-xr-x  1 root wheel   73B May  5 15:45 6b99d060.0 -> ../../../usr/share/certs/trusted/Entrust_Root_Certification_Authority.pem
lrwxr-xr-x  1 root wheel   53B May  5 15:45 6d41d539.0 -> ../../../usr/share/certs/trusted/Amazon_Root_CA_2.pem
lrwxr-xr-x  1 root wheel   77B May  5 15:45 6fa5da56.0 -> ../../../usr/share/certs/trusted/SSL_com_Root_Certification_Authority_RSA.pem
lrwxr-xr-x  1 root wheel   57B May  5 15:45 706f604c.0 -> ../../../usr/share/certs/trusted/XRamp_Global_CA_Root.pem
lrwxr-xr-x  1 root wheel   58B May  5 15:45 749e9e03.0 -> ../../../usr/share/certs/trusted/QuoVadis_Root_CA_1_G3.pem
lrwxr-xr-x  1 root wheel   61B May  5 15:45 75d1b2ed.0 -> ../../../usr/share/certs/trusted/DigiCert_Trusted_Root_G4.pem
lrwxr-xr-x  1 root wheel   55B May  5 15:45 76faf6c0.0 -> ../../../usr/share/certs/trusted/QuoVadis_Root_CA_3.pem
lrwxr-xr-x  1 root wheel   96B May  5 15:45 7719f463.0 -> ../../../usr/share/certs/trusted/Hellenic_Academic_and_Research_Institutions_ECC_RootCA_2015.pem
lrwxr-xr-x  1 root wheel   68B May  5 15:45 773e07ad.0 -> ../../../usr/share/certs/trusted/OISTE_WISeKey_Global_Root_GC_CA.pem
lrwxr-xr-x  1 root wheel   50B May  5 15:45 7a3adc42.0 -> ../../../usr/share/certs/trusted/vTrus_Root_CA.pem
lrwxr-xr-x  1 root wheel   54B May  5 15:45 7a780d93.0 -> ../../../usr/share/certs/trusted/Certainly_Root_R1.pem
lrwxr-xr-x  1 root wheel   64B May  5 15:45 7f3d5d1d.0 -> ../../../usr/share/certs/trusted/DigiCert_Assured_ID_Root_G3.pem
lrwxr-xr-x  1 root wheel   67B May  5 15:45 8160b96c.0 -> ../../../usr/share/certs/trusted/Microsec_e-Szigno_Root_CA_2009.pem
lrwxr-xr-x  1 root wheel   54B May  5 15:45 8508e720.0 -> ../../../usr/share/certs/trusted/Certainly_Root_E1.pem
lrwxr-xr-x  1 root wheel   65B May  5 15:45 865fbdf9.0 -> ../../../usr/share/certs/trusted/SSL_com_TLS_ECC_Root_CA_2022.pem
lrwxr-xr-x  1 root wheel   53B May  5 15:45 8cb5ee0f.0 -> ../../../usr/share/certs/trusted/Amazon_Root_CA_3.pem
lrwxr-xr-x  1 root wheel   53B May  5 15:45 8d86cdd1.0 -> ../../../usr/share/certs/trusted/certSIGN_ROOT_CA.pem
lrwxr-xr-x  1 root wheel   82B May  5 15:45 8d89cda1.0 -> ../../../usr/share/certs/trusted/Microsoft_ECC_Root_Certificate_Authority_2017.pem
lrwxr-xr-x  1 root wheel   53B May  5 15:45 8f103249.0 -> ../../../usr/share/certs/trusted/Telia_Root_CA_v2.pem
lrwxr-xr-x  1 root wheel   82B May  5 15:45 9046744a.0 -> ../../../usr/share/certs/trusted/Sectigo_Public_Server_Authentication_Root_R46.pem
lrwxr-xr-x  1 root wheel   55B May  5 15:45 90c5a3c8.0 -> ../../../usr/share/certs/trusted/HiPKI_Root_CA_-_G1.pem
lrwxr-xr-x  1 root wheel   67B May  5 15:45 930ac5d2.0 -> ../../../usr/share/certs/trusted/Actalis_Authentication_Root_CA.pem
lrwxr-xr-x  1 root wheel   59B May  5 15:45 93bc0acc.0 -> ../../../usr/share/certs/trusted/AffirmTrust_Networking.pem
lrwxr-xr-x  1 root wheel   53B May  5 15:45 9482e63a.0 -> ../../../usr/share/certs/trusted/Certum_EC-384_CA.pem
lrwxr-xr-x  1 root wheel   66B May  5 15:45 9846683b.0 -> ../../../usr/share/certs/trusted/DigiCert_TLS_ECC_P384_Root_G5.pem
lrwxr-xr-x  1 root wheel   81B May  5 15:45 988a38cb.0 -> ../../../usr/share/certs/trusted/NetLock_Arany__Class_Gold__F__tan__s__tv__ny.pem
lrwxr-xr-x  1 root wheel   74B May  5 15:45 9b46e03d.0 -> ../../../usr/share/certs/trusted/Atos_TrustedRoot_Root_CA_RSA_TLS_2021.pem
lrwxr-xr-x  1 root wheel   86B May  5 15:45 9b5697b0.0 -> ../../../usr/share/certs/trusted/Trustwave_Global_ECC_P256_Certification_Authority.pem
lrwxr-xr-x  1 root wheel   60B May  5 15:45 9c8dfbd4.0 -> ../../../usr/share/certs/trusted/AffirmTrust_Premium_ECC.pem
lrwxr-xr-x  1 root wheel   64B May  5 15:45 9d04f354.0 -> ../../../usr/share/certs/trusted/DigiCert_Assured_ID_Root_G2.pem
lrwxr-xr-x  1 root wheel   62B May  5 15:45 9ef4a08a.0 -> ../../../usr/share/certs/trusted/D-TRUST_BR_Root_CA_1_2020.pem
lrwxr-xr-x  1 root wheel   64B May  5 15:45 9f727ac7.0 -> ../../../usr/share/certs/trusted/HARICA_TLS_RSA_Root_CA_2021.pem
lrwxr-xr-x  1 root wheel   48B May  5 15:45 a3418fda.0 -> ../../../usr/share/certs/trusted/GTS_Root_R4.pem
lrwxr-xr-x  1 root wheel   65B May  5 15:45 a89d74c2.0 -> ../../../usr/share/certs/trusted/SSL_com_TLS_RSA_Root_CA_2022.pem
lrwxr-xr-x  1 root wheel   46B May  5 15:45 a94d09e5.0 -> ../../../usr/share/certs/trusted/ACCVRAIZ1.pem
lrwxr-xr-x  1 root wheel   78B May  5 15:45 aee5f10d.0 -> ../../../usr/share/certs/trusted/Entrust_net_Premium_2048_Secure_Server_CA.pem
lrwxr-xr-x  1 root wheel   64B May  5 15:45 b0e59380.0 -> ../../../usr/share/certs/trusted/GlobalSign_ECC_Root_CA_-_R4.pem
lrwxr-xr-x  1 root wheel   64B May  5 15:45 b1159c4c.0 -> ../../../usr/share/certs/trusted/DigiCert_Assured_ID_Root_CA.pem
lrwxr-xr-x  1 root wheel   62B May  5 15:45 b433981b.0 -> ../../../usr/share/certs/trusted/ANF_Secure_Server_Root_CA.pem
lrwxr-xr-x  1 root wheel   53B May  5 15:45 b66938e9.0 -> ../../../usr/share/certs/trusted/Secure_Global_CA.pem
lrwxr-xr-x  1 root wheel   56B May  5 15:45 b727005e.0 -> ../../../usr/share/certs/trusted/AffirmTrust_Premium.pem
lrwxr-xr-x  1 root wheel   70B May  5 15:45 b7a5b843.0 -> ../../../usr/share/certs/trusted/TWCA_Root_Certification_Authority.pem
lrwxr-xr-x  1 root wheel   72B May  5 15:45 b81b93f0.0 -> ../../../usr/share/certs/trusted/AC_RAIZ_FNMT-RCM_SERVIDORES_SEGUROS.pem
lrwxr-xr-x  1 root wheel   82B May  5 15:45 bf53fb88.0 -> ../../../usr/share/certs/trusted/Microsoft_RSA_Root_Certificate_Authority_2017.pem
lrwxr-xr-x  1 root wheel   55B May  5 15:45 c01eb047.0 -> ../../../usr/share/certs/trusted/UCA_Global_G2_Root.pem
lrwxr-xr-x  1 root wheel   67B May  5 15:45 c28a8a30.0 -> ../../../usr/share/certs/trusted/D-TRUST_Root_Class_3_CA_2_2009.pem
lrwxr-xr-x  1 root wheel   70B May  5 15:45 ca6e4ad9.0 -> ../../../usr/share/certs/trusted/ePKI_Root_Certification_Authority.pem
lrwxr-xr-x  1 root wheel   77B May  5 15:45 cbf06781.0 -> ../../../usr/share/certs/trusted/Go_Daddy_Root_Certificate_Authority_-_G2.pem
lrwxr-xr-x  1 root wheel   47B May  5 15:45 cc450945.0 -> ../../../usr/share/certs/trusted/Izenpe_com.pem
lrwxr-xr-x  1 root wheel   67B May  5 15:45 cd58d51e.0 -> ../../../usr/share/certs/trusted/Security_Communication_RootCA2.pem
lrwxr-xr-x  1 root wheel   53B May  5 15:45 cd8c0d63.0 -> ../../../usr/share/certs/trusted/AC_RAIZ_FNMT-RCM.pem
lrwxr-xr-x  1 root wheel   46B May  5 15:45 cd8c0d63.1 -> ../../../usr/local/share/certs/ca-root-nss.crt
lrwxr-xr-x  1 root wheel   53B May  5 15:45 ce5e74ef.0 -> ../../../usr/share/certs/trusted/Amazon_Root_CA_1.pem
lrwxr-xr-x  1 root wheel   70B May  5 15:45 d4dae3dd.0 -> ../../../usr/share/certs/trusted/D-TRUST_Root_Class_3_CA_2_EV_2009.pem
lrwxr-xr-x  1 root wheel   65B May  5 15:45 d52c538d.0 -> ../../../usr/share/certs/trusted/DigiCert_TLS_RSA4096_Root_G5.pem
lrwxr-xr-x  1 root wheel   71B May  5 15:45 d6325660.0 -> ../../../usr/share/certs/trusted/COMODO_RSA_Certification_Authority.pem
lrwxr-xr-x  1 root wheel   55B May  5 15:45 d7e8dc79.0 -> ../../../usr/share/certs/trusted/QuoVadis_Root_CA_2.pem
lrwxr-xr-x  1 root wheel   86B May  5 15:45 d887a5bb.0 -> ../../../usr/share/certs/trusted/Trustwave_Global_ECC_P384_Certification_Authority.pem
lrwxr-xr-x  1 root wheel   82B May  5 15:45 da0cfd1d.0 -> ../../../usr/share/certs/trusted/Sectigo_Public_Server_Authentication_Root_E46.pem
lrwxr-xr-x  1 root wheel   60B May  5 15:45 dc4d6a89.0 -> ../../../usr/share/certs/trusted/GlobalSign_Root_CA_-_R6.pem
lrwxr-xr-x  1 root wheel   60B May  5 15:45 dd8e9d41.0 -> ../../../usr/share/certs/trusted/DigiCert_Global_Root_G3.pem
lrwxr-xr-x  1 root wheel   53B May  5 15:45 de6d66f3.0 -> ../../../usr/share/certs/trusted/Amazon_Root_CA_4.pem
lrwxr-xr-x  1 root wheel   45B May  5 15:45 e113c810.0 -> ../../../usr/share/certs/trusted/Certigna.pem
lrwxr-xr-x  1 root wheel   58B May  5 15:45 e18bfb83.0 -> ../../../usr/share/certs/trusted/QuoVadis_Root_CA_3_G3.pem
lrwxr-xr-x  1 root wheel   59B May  5 15:45 e35234b1.0 -> ../../../usr/share/certs/trusted/Certum_Trusted_Root_CA.pem
lrwxr-xr-x  1 root wheel   58B May  5 15:45 e36a6752.0 -> ../../../usr/share/certs/trusted/Atos_TrustedRoot_2011.pem
lrwxr-xr-x  1 root wheel   68B May  5 15:45 e73d606e.0 -> ../../../usr/share/certs/trusted/OISTE_WISeKey_Global_Root_GB_CA.pem
lrwxr-xr-x  1 root wheel   58B May  5 15:45 e868b802.0 -> ../../../usr/share/certs/trusted/e-Szigno_Root_CA_2017.pem
lrwxr-xr-x  1 root wheel   60B May  5 15:45 e8de2f56.0 -> ../../../usr/share/certs/trusted/Buypass_Class_3_Root_CA.pem
lrwxr-xr-x  1 root wheel   64B May  5 15:45 ecccd8db.0 -> ../../../usr/share/certs/trusted/HARICA_TLS_ECC_Root_CA_2021.pem
lrwxr-xr-x  1 root wheel   54B May  5 15:45 ed858448.0 -> ../../../usr/share/certs/trusted/vTrus_ECC_Root_CA.pem
lrwxr-xr-x  1 root wheel   61B May  5 15:45 ee64a828.0 -> ../../../usr/share/certs/trusted/Comodo_AAA_Services_root.pem
lrwxr-xr-x  1 root wheel   71B May  5 15:45 eed8c118.0 -> ../../../usr/share/certs/trusted/COMODO_ECC_Certification_Authority.pem
lrwxr-xr-x  1 root wheel   67B May  5 15:45 ef954a4e.0 -> ../../../usr/share/certs/trusted/IdenTrust_Commercial_Root_CA_1.pem
lrwxr-xr-x  1 root wheel   56B May  5 15:45 f081611a.0 -> ../../../usr/share/certs/trusted/Go_Daddy_Class_2_CA.pem
lrwxr-xr-x  1 root wheel   80B May  5 15:45 f0c70a8d.0 -> ../../../usr/share/certs/trusted/SSL_com_EV_Root_Certification_Authority_ECC.pem
lrwxr-xr-x  1 root wheel   77B May  5 15:45 f249de83.0 -> ../../../usr/share/certs/trusted/Trustwave_Global_Certification_Authority.pem
lrwxr-xr-x  1 root wheel   74B May  5 15:45 f30dd6ad.0 -> ../../../usr/share/certs/trusted/USERTrust_ECC_Certification_Authority.pem
lrwxr-xr-x  1 root wheel   67B May  5 15:45 f3377b1b.0 -> ../../../usr/share/certs/trusted/Security_Communication_Root_CA.pem
lrwxr-xr-x  1 root wheel   57B May  5 15:45 f387163d.0 -> ../../../usr/share/certs/trusted/Starfield_Class_2_CA.pem
lrwxr-xr-x  1 root wheel   51B May  5 15:45 f39fc864.0 -> ../../../usr/share/certs/trusted/SecureTrust_CA.pem
lrwxr-xr-x  1 root wheel   53B May  5 15:45 f51bb24c.0 -> ../../../usr/share/certs/trusted/Certigna_Root_CA.pem
lrwxr-xr-x  1 root wheel   53B May  5 15:45 fa5da96b.0 -> ../../../usr/share/certs/trusted/GLOBALTRUST_2020.pem
lrwxr-xr-x  1 root wheel   74B May  5 15:45 fb717492.0 -> ../../../usr/share/certs/trusted/Atos_TrustedRoot_Root_CA_ECC_TLS_2021.pem
lrwxr-xr-x  1 root wheel   74B May  5 15:45 fc5a8f99.0 -> ../../../usr/share/certs/trusted/USERTrust_RSA_Certification_Authority.pem
lrwxr-xr-x  1 root wheel   53B May  5 15:45 fd64f3fc.0 -> ../../../usr/share/certs/trusted/TunTrust_Root_CA.pem
lrwxr-xr-x  1 root wheel   52B May  5 15:45 fe8a2cd8.0 -> ../../../usr/share/certs/trusted/SZAFIR_ROOT_CA2.pem
lrwxr-xr-x  1 root wheel   56B May  5 15:45 feffd413.0 -> ../../../usr/share/certs/trusted/GlobalSign_Root_E46.pem
lrwxr-xr-x  1 root wheel   82B May  5 15:45 ff34af3f.0 -> ../../../usr/share/certs/trusted/TUBITAK_Kamu_SM_SSL_Kok_Sertifikasi_-_Surum_1.pem

@TheAssassin
Copy link
Member Author

TheAssassin commented May 5, 2024 •
edited
Loading

Works fine on helloSystem in my test. Are you sure you used the latest binaries?

@probonopd
Copy link
Member

probonopd commented May 5, 2024 •
edited
Loading

Hold on... retesting.

Edit:

Are you sure you used the latest binaries?

Apparently I didn't, see below. Sorry for the noise.

@TheAssassin
Copy link
Member Author

FYI, I want to improve the history, so please leave the merge to me once you approve the changes. I'll take care of it.

@TheAssassin TheAssassin changed the title Handle nullptr properly Fix detection of usable CA certificate bundle May 5, 2024
@probonopd
Copy link
Member

Can confirm that the latest build works on CentOS Linux release 7.9.2009 (Core) on WSL2. Now for FreeBSD...

@probonopd
Copy link
Member

Also confirm that the latest build works on FreeBSD 14.0-RELEASE. Great Job! 👍

TheAssassin added 2 commits May 5, 2024 21:20
@TheAssassin
Fix missing spaces in log message
92f8d7a
@TheAssassin
Fix CA certificate chain lookup logic
707207f 
When the values libcurl provides as defaults are broken, they should be
unset or replaced with working ones. Therefore, we now probe them, unset
broken ones and then run our detection logic if the values have not been
set.

This should make sure both values are either set with a seemingly usable
path or unset.

When neither of the values work, we log a warning. Then, the included
locations can be amended, if possible.
@TheAssassin TheAssassin merged commit 168afd1 into main May 5, 2024
10 checks passed
@TheAssassin TheAssassin deleted the fix-nullptr branch May 5, 2024 19:30
@TheAssassin TheAssassin mentioned this pull request May 5, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@probonopd probonopd probonopd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TheAssassin @probonopd