[Bug] Fixed a bug when passing icon as a widget to TabItem #15
+122
−55
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding a widget as an icon to TabItem as follows (any type of widget will suffice):
TabItem<Widget>(icon: SvgPicture.asset(Assets.iconsConversation), title: "Home"),
will cause an exception even when specifying the icon type to Widget and not IconData. The bug is caused by the they following line in build_icon.dart :
since the item.icon type will be considered an IconData even if specified as widget, this is fixed by adding the following check: