Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: label issues #72

Merged
merged 8 commits into from
Apr 27, 2024
Merged

fix: label issues #72

merged 8 commits into from
Apr 27, 2024

Conversation

mikeshultz
Copy link
Contributor

@mikeshultz mikeshultz commented Apr 24, 2024

What I did

Fixes a label issue I ran across during testing. Also added a couple of labels useful for distributed runner/worker.

Checklist

  • Passes all linting checks (pre-commit and CI jobs)
  • New test cases have been added and are passing
  • Documentation has been updated
  • PR title follows Conventional Commit standard (will be automatically included in the changelog)

@mikeshultz mikeshultz added the bug Something isn't working label Apr 24, 2024
@mikeshultz mikeshultz self-assigned this Apr 24, 2024
@mikeshultz
Copy link
Contributor Author

Tests waiting on #73

silverback/middlewares.py Outdated Show resolved Hide resolved
silverback/application.py Outdated Show resolved Hide resolved
fubuloubu
fubuloubu previously approved these changes Apr 25, 2024
setup.py Outdated Show resolved Hide resolved
@@ -69,6 +69,7 @@
install_requires=[
"click", # Use same version as eth-ape
"eth-ape>=0.7.0,<1.0",
"ethpm-types>=0.6.10", # lower pin only, `eth-ape` governs upper pin
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mikeshultz mikeshultz merged commit 5e7f513 into main Apr 27, 2024
25 checks passed
@mikeshultz mikeshultz deleted the feat/event-labels branch April 27, 2024 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants