Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor!: rename Persistence to Recorder #63

Merged
merged 3 commits into from
May 1, 2024

Conversation

fubuloubu
Copy link
Member

What I did

I made a naming change that more accurately follows our intended platform naming for this subsystem

How I did it

find/replace

How to verify it

Should be no change in functionality other than the environment variable you need to use to set it up

Checklist

  • Passes all linting checks (pre-commit and CI jobs)
  • New test cases have been added and are passing
  • Documentation has been updated
  • PR title follows Conventional Commit standard (will be automatically included in the changelog)

@fubuloubu fubuloubu requested a review from mikeshultz April 2, 2024 21:23
mikeshultz
mikeshultz previously approved these changes Apr 9, 2024
Copy link
Contributor

@mikeshultz mikeshultz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will be a breaking change for chaosnet.

Copy link
Contributor

@johnson2427 johnson2427 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did my own grep and search, lgtm

@fubuloubu
Copy link
Member Author

Planning this one for v0.4

@fubuloubu fubuloubu merged commit d315640 into main May 1, 2024
25 of 26 checks passed
@fubuloubu fubuloubu deleted the refactor/persistence-recorder branch May 1, 2024 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants