Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove bots error #190

Closed
wants to merge 1 commit into from
Closed

Conversation

dtdang
Copy link
Contributor

@dtdang dtdang commented Jan 17, 2025

What I did

Removing cluster bots error command since logs and errors are no longer separated.

fixes: SBK-622

How I did it

How to verify it

Checklist

  • Passes all linting checks (pre-commit and CI jobs)
  • New test cases have been added and are passing
  • Documentation has been updated
  • PR title follows Conventional Commit standard (will be automatically included in the changelog)

@dtdang dtdang requested a review from fubuloubu January 17, 2025 20:32
@fubuloubu
Copy link
Member

I think something might be lost in translation, we might not have the proper "errors" feature implemented in the cluster right now, but errors and logs are indeed pretty different features with different endpoints

The way errors should work is the CCS should end up tracking each time a task has an error, and then the information that error has (notably the timestamp) allows us to link over to the logs feature to display the full context around the error.

The "logs" feature is just captured logs from running that bot, which doesn't care if errors occur

@dtdang dtdang closed this Jan 21, 2025
@dtdang dtdang deleted the fix/remove_bot_errors branch January 21, 2025 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants