Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update workspaces #156

Merged
merged 6 commits into from
Oct 26, 2024
Merged

Conversation

dtdang
Copy link
Contributor

@dtdang dtdang commented Oct 25, 2024

What I did

Fix workspaces update subcommand so that values could be None and original values would not be overwritten.

fixes: #

How I did it

How to verify it

Checklist

  • Passes all linting checks (pre-commit and CI jobs)
  • New test cases have been added and are passing
  • Documentation has been updated
  • PR title follows Conventional Commit standard (will be automatically included in the changelog)

@dtdang dtdang requested a review from fubuloubu October 25, 2024 18:43
silverback/_cli.py Outdated Show resolved Hide resolved
silverback/_cli.py Outdated Show resolved Hide resolved
silverback/cluster/client.py Outdated Show resolved Hide resolved
fubuloubu
fubuloubu previously approved these changes Oct 25, 2024
Copy link
Member

@fubuloubu fubuloubu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one comment (do to both)

@fubuloubu fubuloubu merged commit c5cb374 into ApeWorX:main Oct 26, 2024
13 checks passed
@dtdang dtdang deleted the fix/update_workspaces branch October 26, 2024 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants