feat: allow setting sign=False on transactions (good for titanoboa)
#2486
+43
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antazoey
changed the title
sign=False on transactionssign=False on transactions (good for titanoboa)
bitwise-constructs
previously approved these changes
Jan 31, 2025
antazoey
force-pushed
the
feat/sign-false
branch
from
75fc5d2 to
ecb07be
Compare
antazoey
force-pushed
the
feat/sign-false
branch
from
ecb07be to
905928c
Compare
dtdang
approved these changes
Jan 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
allows setting
sign=Falsewhen making transactions.I am thinking this is the first step to getting a faster titanoboa integration, helps us avoid signing the transactions
How I did it
How to verify it
Checklist