Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: mistaken blob receipt causing serialization problems #2345

Merged
merged 4 commits into from
Oct 26, 2024

Conversation

antazoey
Copy link
Member

What I did

fixes: #2329

basically the problem was that tenderly nodes gave us a field blobGasUsed: 0 for non-blob receipts (didn't see that field from other nodes so assuming is a bug).

How I did it

in this case, if there is no blobGasPrice at all, just use the regular receipt cls instead, which makes the detection for shared blob receipt data extra strict

How to verify it

node:
  ethereum:
    mainnet:
      uri: https://gateway.tenderly.co/public/mainnet

and

In [1]: txn_hash = '0x62fc9991bc7fb0c76bc83faaa8d1c17fc5efb050542e58ac358932f80aa7a087'

In [2]: provider.get_receipt(txn_hash)

Checklist

  • All changes are completed
  • New test cases have been added
  • Documentation has been updated

@antazoey antazoey requested a review from fubuloubu October 26, 2024 17:51
@antazoey antazoey enabled auto-merge (squash) October 26, 2024 19:56
@antazoey antazoey merged commit 6b584a2 into ApeWorX:main Oct 26, 2024
16 checks passed
@antazoey antazoey deleted the fix/blob-receipt-no-gas-price branch October 26, 2024 23:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sepolia Receipt Bug (blobGasPrice Input should be valid integer)
2 participants