Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor!: Upgrade Ethereum packages and usage #2222

Merged
merged 1 commit into from
Oct 1, 2024

Conversation

antazoey
Copy link
Member

What I did

in prep for the eth upgrades, we need to do this

How I did it

How to verify it

Checklist

  • All changes are completed
  • New test cases have been added
  • Documentation has been updated

@antazoey antazoey force-pushed the fix/eth-upgrade branch 3 times, most recently from 9459683 to 3f2c7f0 Compare August 16, 2024 23:44
fubuloubu
fubuloubu previously approved these changes Aug 19, 2024
@antazoey antazoey changed the title refactor: change all <bytes>.hex() to to_hex() refactor: Upgrade Ethereum APIs Aug 19, 2024
@antazoey antazoey changed the title refactor: Upgrade Ethereum APIs refactor: Upgrade Ethereum packages and usage Aug 19, 2024
@antazoey antazoey changed the title refactor: Upgrade Ethereum packages and usage refactor!: Upgrade Ethereum packages and usage Aug 19, 2024
@antazoey
Copy link
Member Author

shares most with #2223 but this one is the breaking changes version.
the diff will be much simpler after 2223.
unfortunately we cant update web3.py officially until we are ready for 0.9 as it breaks plugins

Copy link
Member

@fubuloubu fubuloubu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems like some changes are mixed together in here?

@antazoey
Copy link
Member Author

seems like some changes are mixed together in here?

The base path is out of date.

@antazoey antazoey merged commit 51259b2 into ApeWorX:feat/0-9 Oct 1, 2024
14 checks passed
@antazoey antazoey deleted the fix/eth-upgrade branch October 1, 2024 15:49
@bitwise-constructs
Copy link
Contributor

upgrading to web3.py>7 will allow ApeWorX/ape-polygon#33 to be fixed

@antazoey
Copy link
Member Author

antazoey commented Oct 2, 2024

upgrading to web3.py>7 will allow ApeWorX/ape-polygon#33 to be fixed

itll be a while until 0.9 is out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants