-
-
Notifications
You must be signed in to change notification settings - Fork 146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: use uv
if installed for ape plugins
install / uninstall commands
#2000
feat: use uv
if installed for ape plugins
install / uninstall commands
#2000
Conversation
I think I made uv a stand-in replacement for pip only if it's installed saw some warnings along the way:
|
e16e99e
to
8368de2
Compare
evm-trace has a capped dependency on py-evm versions which use pkg_resources. I remove it here: ApeWorX/evm-trace#62 |
uncapping python-dateutil, eth-account, eth-utils, web3[tester], and eip712 points to the culprit:
uv has really nice dependency errors :) my guess is eip712 needs to be updated to be uncapped |
uncapping and bumping pandas to >=2 lets uv pick 2.2.2 instead of 1.5.3 (why that one? i dunno... probably picking the oldest version that meets criteria?) 1.5.3 results in a hecking weird error:
that version is from Jan 19, 2023 so imma say it's just busted error is now back to pkg_resources usage in eth_tester |
cd8cff3
to
8c4ad95
Compare
8c4ad95
to
60d2829
Compare
rebased. got it installed with eth_account==0.11.2 by uncapping eth-account in ape and eip712. also PS: lol pip can't install |
now functional tests fail. I have no idea how difficult the required changes would be. I think I went off the deep end trying not to use setuptools. spinning off efforts:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks
The pkg_resources problem is annoying. Thankfully it is going away anyway as part of adding Python 3.12 support.
having PIP_COMMAND in _utils creates a circular dependency:
this can be resolved by:
|
to resolve the circular dependency above, moved PluginManager to src/ape/managers/plugins.py and clean_plugin_name to ape/plugins/_utils |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Re-ran failed test case for Python 3.9
I'm okay with the move of the PluginManager
but curious what @antazoey thinks
I like the change but am worried if it's breaking. |
It lifts The expectation is that singletons from |
Looks like freak CI accident. Only MacOS Python 3.10 failed. Here's the failing test. Looks like the CI runner just dropped a file or something.
|
Yes we are tracking to fix with #2020 |
awesome. let me know if this PR is missing anything. maybe we can revisit after #2020. |
during testing I ran into an issue but fixed it here: #2021 |
Issue:
edit: fixed w/ tests |
issues: tests fail when edit: fixed |
15c18a4
to
0e71415
Compare
uv
if installeduv
if installed for ape plugins
install / uninstall commands
issue:
|
64b58be
to
5b689b5
Compare
5b689b5
to
bd50c36
Compare
Just realized - if this is working, then #1994 should too now. |
just tested installation speeds between uv and pip, on latest 0.7.23 26bec8b:
also, big speedup comes from loosening the pandas pin, which requires building numpy on my machine (Fedora 40) |
Yeah, we actually want to remove the pandas pin eventually, it's not quite state of the art and end users might have a couple of different options they may want to choose from |
What I did
add setuptools and pip to base requirements so that
uv
can install everything correctly.fixes: #1999
fixes: #
How I did it
edited the setup.cfg
How to verify it
Checklist