docs: Chainstack implementation update #4
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: NotPeopling2day <[email protected]>
|
I updated the base code so that it was a little more functional and added a couple tests. Unfortunately it will require you to rebase/fix conflicts. |
antazoey
reviewed
Aug 1, 2022
|
|
||
| ```bash | ||
| ape console --network ethereum:ropsten:chainstack | ||
| ape console --network chainstack |
There was a problem hiding this comment.
You can see the complete list by doing ape networks list. I think we should document it that way instead because it does not then require putting in an errornous command.
There was a problem hiding this comment.
My idea with this is to show the user the syntax to use and all the different options. But I'm ok removing that part if you prefer, the part above it shows the ape networks list command anyway 😄
Co-authored-by: Juliya Smith <[email protected]>
Co-authored-by: Juliya Smith <[email protected]>
|
I think I'll close this PR and re-fork the updated code. I'll test it and if it works I'll open another PR just to update the README! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
provider.pytoproviders.py.__init__.py.How I did it
Forked and modified my branch.
Ran pre-commit
Checklist