Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chmod +x before executing ./gradlew #28

Merged
merged 1 commit into from
Mar 29, 2024
Merged

chmod +x before executing ./gradlew #28

merged 1 commit into from
Mar 29, 2024

Conversation

code-explorer786
Copy link
Contributor

haven't tested yet but i guess it'll work

this might be a problem for modders who use Windows, since Windows drops
the executable bit
@Anuken
Copy link
Owner

Anuken commented Mar 26, 2024

Why? Just set the bit in the file.

@code-explorer786
Copy link
Contributor Author

code-explorer786 commented Mar 29, 2024

Windows systems don't support the Unix executable bit.
I expect Git to handle this properly (I read docs, but I haven't touched a Windows system since), but sometimes there's an incident where Git follows along with the filesystem it's in - and adds disabling ./gradlew's executable bit with whatever commit the mod developer just made. After that, there's no way the mod developer can re-enable the executable bit on Windows.

This PR is purely for convenience; I don't think anyone else on the modding community knows what a core.fileMode is.

@Anuken
Copy link
Owner

Anuken commented Mar 29, 2024

Ugh, windows...

@Anuken Anuken merged commit dc6736d into Anuken:master Mar 29, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants