update localisation. Tidy code

.editorconfig

@@ -299,3 +299,9 @@ dotnet_diagnostic.S3928.severity = silent
 
 # SA1009: Closing parenthesis should be spaced correctly
 dotnet_diagnostic.SA1009.severity = silent
+
+# CC0021: Use nameof
+dotnet_diagnostic.CC0021.severity = silent
+
+# CC0022: Should dispose object
+dotnet_diagnostic.CC0022.severity = silent

OnlyM.Core/Services/CommandLine/CommandLineService.cs

@@ -54,11 +54,13 @@ public CommandLineService()
                 }
             }
 #pragma warning disable RCS1075 // Avoid empty catch clause that catches System.Exception.
+#pragma warning disable CC0004 // Catch block cannot be empty
             catch (Exception)
-#pragma warning restore RCS1075 // Avoid empty catch clause that catches System.Exception.
             {
                 // ignored
             }
+#pragma warning restore CC0004 // Catch block cannot be empty
+#pragma warning restore RCS1075 // Avoid empty catch clause that catches System.Exception.
 
             return null;
         }

OnlyM.Core/Services/WebShortcuts/WebShortcutHelper.cs

@@ -54,11 +54,13 @@ private void Init()
                     }
                 }
 #pragma warning disable RCS1075 // Avoid empty catch clause that catches System.Exception.
+#pragma warning disable CC0004 // Catch block cannot be empty
                 catch (Exception)
-#pragma warning restore RCS1075 // Avoid empty catch clause that catches System.Exception.
                 {
                     // nothing
                 }
+#pragma warning restore CC0004 // Catch block cannot be empty
+#pragma warning restore RCS1075 // Avoid empty catch clause that catches System.Exception.
                 finally
                 {
                     _initialised = true;

OnlyM.CoreSys/GraphicsUtils.cs

@@ -64,10 +64,14 @@ public static bool AutoRotateIfRequired(string? itemFilePath)
             {
                 AutoRotateIfRequired(itemFilePath);
 
-                var settings = new ProcessImageSettings { Width = width, Height = height };
-                settings.ResizeMode = CropScaleMode.Pad;
-                settings.MatteColor = System.Drawing.Color.Black;
-
+                var settings = new ProcessImageSettings
+                {
+                    Width = width, 
+                    Height = height, 
+                    ResizeMode = CropScaleMode.Pad, 
+                    MatteColor = System.Drawing.Color.Black
+                };
+
                 using var outStream = new MemoryStream();
                 MagicImageProcessor.ProcessImage(itemFilePath, outStream, settings);
                 outStream.Seek(0L, SeekOrigin.Begin);

OnlyM/Services/MetaDataQueue/MetaDataQueueProducer.cs

@@ -8,7 +8,7 @@ namespace OnlyM.Services.MetaDataQueue
 {
     internal sealed class MetaDataQueueProducer : IDisposable
     {
-        public BlockingCollection<MediaItem> Queue { get; } = new BlockingCollection<MediaItem>();
+        public BlockingCollection<MediaItem> Queue { get; } = new();
 
         public void Add(MediaItem mediaItem)
         {

OnlyM/Services/Pages/PageService.cs

@@ -119,10 +119,7 @@ public void GotoOperatorPage()
 
         public void GotoSettingsPage()
         {
-#pragma warning disable SA1312 // Variable names should begin with lower-case letter
-            var _ = _settingsPage.Value;   // ensure created otherwise doesn't receive navigation event
-#pragma warning restore SA1312 // Variable names should begin with lower-case letter
-
+            _ = _settingsPage.Value;   // ensure created otherwise doesn't receive navigation event
             _operatorPageScrollerPosition = ScrollViewer?.VerticalOffset ?? 0.0;
             OnNavigationEvent(new NavigationEventArgs { PageName = SettingsPageName });
         }

OnlyM/ViewModel/OperatorViewModel.cs

@@ -1200,7 +1200,7 @@ private void HandleAllowMirrorChangedEvent(object? sender, EventArgs e)
         private static bool IsInDesignMode()
         {
 #if DEBUG
-            DependencyObject dep = new();
+            var dep = new DependencyObject();
             return DesignerProperties.GetIsInDesignMode(dep);
 #else
             return false;

OnlyM/ViewModel/SettingsViewModel.cs

@@ -1215,10 +1215,12 @@ private static LanguageItem[] GetSupportedLanguages()
                             LanguageName = c.EnglishName,
                         });
                     }
+#pragma warning disable CC0004 // Catch block cannot be empty
                     catch (CultureNotFoundException)
                     {
                         // expected
                     }
+#pragma warning restore CC0004 // Catch block cannot be empty
                 }
             }
 

OnlyM/Windows/OperatorPage.xaml.cs

@@ -43,7 +43,7 @@ private static void HandleMirrorCheckBoxChanged(object? sender, bool isChecked)
 
         private void OnlyMOperatorPage_SizeChanged(object? sender, SizeChangedEventArgs e)
         {
-            OperatorViewModel vm = (OperatorViewModel)DataContext;
+            var vm = (OperatorViewModel?)DataContext;
 
             if (vm == null)
             {

OnlyMSlideManager/ViewModel/MainViewModel.cs

@@ -77,9 +77,7 @@ public MainViewModel(
             AddDesignTimeItems();
 
             // init options so that UI locale is set (forces lazy init)
-#pragma warning disable SA1312 // Variable names should begin with lower-case letter
-            var _ = _optionsService.Culture;
-#pragma warning restore SA1312 // Variable names should begin with lower-case letter
+            _ = _optionsService.Culture;
 
             InitCommands();
             WeakReferenceMessenger.Default.Register<ReorderMessage>(this, OnReorderMessage);
@@ -1021,10 +1019,12 @@ private static LanguageItem[] GetSupportedLanguages()
                             LanguageName = c.EnglishName,
                         });
                     }
+#pragma warning disable CC0004 // Catch block cannot be empty
                     catch (CultureNotFoundException)
                     {
                         // expected
                     }
+#pragma warning restore CC0004 // Catch block cannot be empty
                 }
             }
 
@@ -1050,7 +1050,7 @@ private string GetStandardStatusText()
         private static bool IsInDesignMode()
         {
 #if DEBUG
-            DependencyObject dep = new();
+            var dep = new DependencyObject();
             return DesignerProperties.GetIsInDesignMode(dep);
 #else
             return false;

SolutionInfo.cs

@@ -8,4 +8,4 @@
 [assembly: AssemblyCulture("")]
 [assembly: NeutralResourcesLanguage("en-GB")]
 
-[assembly: AssemblyVersion("2.0.0.11")]
+[assembly: AssemblyVersion("2.0.0.12")]