Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enable several rules from revive #164

Merged
merged 2 commits into from
Aug 29, 2024
Merged

enable several rules from revive #164

merged 2 commits into from
Aug 29, 2024

Conversation

mmorel-35
Copy link

@mmorel-35 mmorel-35 commented Jul 4, 2024 •
edited by Antonboom
Loading

Closes #158

@coveralls
Copy link

coveralls commented Jul 4, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9798828212

Details

  • 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.003%) to 93.689%
Totals Coverage Status
Change from base Build 9743211634: -0.003%
Covered Lines: 2212
Relevant Lines: 2361
💛 - Coveralls

@ccoVeille
Copy link
Contributor

We might need to enable more, but this one is great.
I didn't have a chance to keep working on https://github.com/ccoVeille/golangci-lint-config-examples

I think we could also enable

  • empty-block
  • if-return
  • identical-branch
  • indent-error-flow
  • superfluous-else
  • unreachable-code
  • useless-break

All these are safe and works perfectly with early-return

@mmorel-35 mmorel-35 changed the title enable early-return rule from revive enable several rules from revive Jul 4, 2024
@coveralls
Copy link

coveralls commented Jul 4, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9799145161

Details

  • 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.003%) to 93.689%
Totals Coverage Status
Change from base Build 9743211634: -0.003%
Covered Lines: 2212
Relevant Lines: 2361
💛 - Coveralls

@coveralls
Copy link

coveralls commented Jul 4, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9799180994

Details

  • 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.003%) to 93.689%
Totals Coverage Status
Change from base Build 9743211634: -0.003%
Covered Lines: 2212
Relevant Lines: 2361
💛 - Coveralls

ccoVeille
ccoVeille approved these changes Jul 4, 2024
View reviewed changes
Copy link
Contributor

@ccoVeille ccoVeille left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@mmorel-35 mmorel-35 force-pushed the revive/early-return branch from e499a80 to 9320430 Compare July 7, 2024 09:26
@coveralls
Copy link

coveralls commented Jul 7, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9826233598

Details

  • 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.003%) to 93.689%
Totals Coverage Status
Change from base Build 9743211634: -0.003%
Covered Lines: 2212
Relevant Lines: 2361
💛 - Coveralls

@Antonboom Antonboom enabled auto-merge (squash) August 29, 2024 05:05
@Antonboom Antonboom merged commit 93f4963 into Antonboom:master Aug 29, 2024
3 checks passed
@coveralls
Copy link

Pull Request Test Coverage Report for Build 10609022856

Details

  • 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.003%) to 93.689%
Totals Coverage Status
Change from base Build 10608990804: -0.003%
Covered Lines: 2212
Relevant Lines: 2361
💛 - Coveralls

@mmorel-35 mmorel-35 deleted the revive/early-return branch August 29, 2024 06:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Antonboom Antonboom Antonboom approved these changes

@ccoVeille ccoVeille ccoVeille approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Consider adding optional revive linters
4 participants
@mmorel-35 @coveralls @ccoVeille @Antonboom