Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Suggest NotEmpty for Positive len #124

Merged
merged 2 commits into from
Jun 15, 2024
Merged

Suggest NotEmpty for Positive len #124

merged 2 commits into from
Jun 15, 2024

Conversation

mmorel-35
Copy link

@mmorel-35 mmorel-35 commented Jun 14, 2024 •
edited
Loading

Closes #122

@coveralls
Copy link

coveralls commented Jun 14, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9511868398

Details

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 93.611%
Totals Coverage Status
Change from base Build 9431505288: 0.0%
Covered Lines: 2110
Relevant Lines: 2254
💛 - Coveralls

@coveralls
Copy link

coveralls commented Jun 14, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9511883615

Details

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 93.611%
Totals Coverage Status
Change from base Build 9431505288: 0.0%
Covered Lines: 2110
Relevant Lines: 2254
💛 - Coveralls

@mmorel-35 mmorel-35 mentioned this pull request Jun 14, 2024
Closed
ccoVeille
ccoVeille approved these changes Jun 14, 2024
View reviewed changes
Copy link
Contributor

@ccoVeille ccoVeille left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Antonboom Antonboom merged commit 858de46 into Antonboom:master Jun 15, 2024
3 checks passed
@coveralls
Copy link

coveralls commented Jun 15, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9525739279

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 93.611%
Totals Coverage Status
Change from base Build 9431505288: 0.0%
Covered Lines: 2110
Relevant Lines: 2254
💛 - Coveralls

@mmorel-35 mmorel-35 deleted the issue-122 branch June 15, 2024 07:00
@Antonboom Antonboom mentioned this pull request Jun 21, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ccoVeille ccoVeille ccoVeille approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

len+compare: false-positive on assert.True(t, len(myarray) > 0)
4 participants
@mmorel-35 @coveralls @ccoVeille @Antonboom