refactor generator #121
Merged
refactor generator #121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 9436791382Details
💛 - Coveralls |
|
This PR uses commits available in: |
|
@Antonboom do you think we could merge this one, it would help me to refactor for |
Antonboom
requested changes
Jun 14, 2024
internal/testgen/gen_bool_compare.go
Outdated
| Assertion{Fn: "False", Argsf: "foo != foo"}, | ||
| ) | ||
|
|
||
| invalidAssertionsForTrue := make([]Assertion, 0) |
internal/testgen/gen_bool_compare.go
Outdated
| ) | ||
|
|
||
| invalidAssertionsForTrue := make([]Assertion, 0) | ||
| invalidAssertionsForFalse := make([]Assertion, 0) |
internal/testgen/gen_bool_compare.go
Outdated
| ) | ||
| } | ||
|
|
||
| sortAssertions(invalidAssertionsForTrue) |
There was a problem hiding this comment.
any reason to sort it?
the order of assertions is determined
safe this PR from unrelated changes around generated test files
There was a problem hiding this comment.
I will remove it then
ccoVeille
force-pushed
the
refactor-generator
branch
from
63fab08 to
9cf6c96
Compare
Pull Request Test Coverage Report for Build 9511399411Details
💛 - Coveralls |
|
I pushed too fast sorry. I will fix other too |
ccoVeille
force-pushed
the
refactor-generator
branch
from
9cf6c96 to
c6c18dd
Compare
Pull Request Test Coverage Report for Build 9513179523Details
💛 - Coveralls |
ccoVeille
force-pushed
the
refactor-generator
branch
from
c6c18dd to
8ade9bf
Compare
|
I resolved all your comments @Antonboom please check and review. The number of changes is then very limited |
Pull Request Test Coverage Report for Build 9513220198Details
💛 - Coveralls |
Pull Request Test Coverage Report for Build 9525679838Details
💛 - Coveralls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These commits were part of
#107and #111 that were suggested changes were discarded, but the refactoring made in each PR could be kept as discussed here