Add claude 3 / anthropic with cost calculation + convenience fixes. gpt-engineer is coauthor #1057
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…anthropic-cost-calc * 'main' of github.com:gpt-engineer-org/gpt-engineer: poetry update Add support for claude 3 (#1055) updating cache updated cache clarified file format prompt aligning improve prompt with generate prompt
AntonOsika
changed the title
ErikBjare
approved these changes
Mar 14, 2024
|
@AntonOsika, can you check these tests so we can proceed with this? |
ErikBjare
reviewed
Mar 18, 2024
|
Fixed the remaining issues (afaik). Merging as soon as tests pass. |
|
Looks like there were more issues and broken tests. Not quite as easy as I thought to clean up. |
ErikBjare
reviewed
Mar 18, 2024
gpt_engineer/core/ai.py
Outdated
| @@ -110,7 +110,7 @@ def __init__( | |||
|
|
|||
| logger.debug(f"Using model {self.model_name}") | |||
|
|
|||
| def start(self, system: str, user: str, step_name: str) -> List[Message]: | |||
| def start(self, system: str, user: str, *, step_name: str) -> List[Message]: | |||
There was a problem hiding this comment.
What was the idea with this *?
Edit: removed it because it broke several tests that I didn't want to go through.
|
Reviewing this PR has made me realize that we need to typecheck the codebase in CI: #1070 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.