Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restructuration of the functions' calls in the script to make it more readable and easier to evolve/work with #68

Merged
merged 4 commits into from
Dec 1, 2023

Conversation

Antiz96
Copy link
Owner

@Antiz96 Antiz96 commented Dec 1, 2023

This MR aims to restructure the functions calls so they are now completely independent from each other, in the sense that no function is making a direct call to another one anymore (except for the 'changing icon' ones).

This makes the script more readable and easier to evolve/work with, as now the functions calls are centralized in the last 'case' statement instead of having both the 'list_packages' and the 'update' function calling other functions depending on certains parameters (which made adding a new function unnecessarily complex).

… readable and easier to evolve/work with

This commit aims to restructure the functions calls so they are now completely independant from each other, in the sense that no function is making a direct call to another one anymore (except for the 'changing icon' ones).

This makes the script more readable and easier to evolve/work with, as now the functions calls are centralized in the last 'case' statement instead of having both the 'list_packages' and the 'update' function calling other functions depending on certains parameters (which made adding a new function unnecessarilly complex).
Copy link
Owner Author

@Antiz96 Antiz96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Antiz96 Antiz96 merged commit 79dc68d into main Dec 1, 2023
1 check passed
@Antiz96 Antiz96 deleted the restructure branch December 1, 2023 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant