feat: add BFF tests and updated detection #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Patterbear
changed the title
|
The user was being notified of a macro being detected and removed despite file being bleached. This is due to the fact that the streams that macros are stored in still exist, although are filled with empty bytes. To resolve this I added a stream content check to determine whether or not to bleach and notify. |
rothoma2
approved these changes
Oct 25, 2024
|
Looks Great to me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have added tests for the supported BFF file types (.xls and .doc - sadly .ppt is still an open issue).
I updated the macro detection function to check that macro streams have been successfully been wiped (by replacing their contents with empty bytes), if the file is a supported BFF file type.
I updated the BFF removal to use 'with' as 'ole.close()' was causing permission errors.
I left a few comments to explain the BFF bleach and detect processes, but these can be removed if they don't meet clean code standards.