-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Adding Github Unittests workflow #22
feat: Adding Github Unittests workflow #22
Conversation
6c9b8b6
to
7c47162
Compare
7c47162
to
f026ff7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know this may be the default github action way of doing unit tests, but I originally wrote all the tests with pytest and I feel it was less complicated and more readable, and also because it allows for a variety of tests,.
I personally prefer a more modular, purely functional testing approach, however if @rothoma2 feels unittest and this current format you've used should be the standard, then that's all good and i'll write future tests this way.
Anyway, the actions and the tests look pretty good.
I do agree it would be nice to find a way to use pytest, I believe pytest is the standard modern way of doing unit tests in python. |
Im not very familiar woth force pushes and multiple people on the same branch. I think normally each one will have its own branch and you will merge one into master and then merge master into branch two before creating the second pullrequest. In between you can always merge branch A into Branch2 if u need to pull changes into your branch. |
@lucifercr07 Will you change this back to use pytest, or should we drop this PullRequest? Making sure it doesnt linger for too long. |
f026ff7
to
7fd60c2
Compare
db978a2
to
81d9431
Compare
No description provided.