Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Adding Github Unittests workflow #22

Merged
merged 46 commits into from
Jun 19, 2024

Conversation

lucifercr07
Copy link
Contributor

No description provided.

@lucifercr07 lucifercr07 force-pushed the lucifercr07/adding_unit_tests_pre_commit_hook branch 6 times, most recently from 6c9b8b6 to 7c47162 Compare June 13, 2024 09:36
@lucifercr07 lucifercr07 requested review from rothoma2 and Patterbear and removed request for rothoma2 June 13, 2024 09:42
@lucifercr07 lucifercr07 force-pushed the lucifercr07/adding_unit_tests_pre_commit_hook branch from 7c47162 to f026ff7 Compare June 13, 2024 10:10
Copy link
Member

@Patterbear Patterbear left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know this may be the default github action way of doing unit tests, but I originally wrote all the tests with pytest and I feel it was less complicated and more readable, and also because it allows for a variety of tests,.

I personally prefer a more modular, purely functional testing approach, however if @rothoma2 feels unittest and this current format you've used should be the standard, then that's all good and i'll write future tests this way.

Anyway, the actions and the tests look pretty good.

@rothoma2
Copy link
Contributor

I do agree it would be nice to find a way to use pytest, I believe pytest is the standard modern way of doing unit tests in python.

@rothoma2
Copy link
Contributor

Im not very familiar woth force pushes and multiple people on the same branch.

I think normally each one will have its own branch and you will merge one into master and then merge master into branch two before creating the second pullrequest.

In between you can always merge branch A into Branch2 if u need to pull changes into your branch.

.github/workflows/unit-tests.yml Outdated Show resolved Hide resolved
@rothoma2
Copy link
Contributor

@lucifercr07 Will you change this back to use pytest, or should we drop this PullRequest? Making sure it doesnt linger for too long.

@lucifercr07 lucifercr07 force-pushed the lucifercr07/adding_unit_tests_pre_commit_hook branch from f026ff7 to 7fd60c2 Compare June 18, 2024 11:37
@lucifercr07 lucifercr07 force-pushed the lucifercr07/adding_unit_tests_pre_commit_hook branch from db978a2 to 81d9431 Compare June 19, 2024 05:55
@Patterbear Patterbear changed the base branch from main to lucifercr07/adding_linter_pre_commit_hook June 19, 2024 06:43
@Patterbear Patterbear changed the base branch from lucifercr07/adding_linter_pre_commit_hook to main June 19, 2024 07:14
@Patterbear Patterbear merged commit fe8a59c into main Jun 19, 2024
6 checks passed
@Patterbear Patterbear deleted the lucifercr07/adding_unit_tests_pre_commit_hook branch June 19, 2024 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants