Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Adding Github workflows #21

Merged
merged 1 commit into from
Jun 12, 2024
Merged

feat: Adding Github workflows #21

merged 1 commit into from
Jun 12, 2024

Conversation

lucifercr07
Copy link
Contributor

Changes done:

  1. Added Linter
  2. Added PR semantic validator
  3. Added auto-assign PR plugin
  4. Fixed flake8 issues

@lucifercr07 lucifercr07 force-pushed the lucifercr07/adding_linter_pre_commit_hook branch 2 times, most recently from 2b310fc to 12082a0 Compare June 11, 2024 10:55
@lucifercr07 lucifercr07 self-assigned this Jun 11, 2024
@lucifercr07 lucifercr07 force-pushed the lucifercr07/adding_linter_pre_commit_hook branch from 12082a0 to 3003566 Compare June 11, 2024 11:01
Patterbear
Patterbear reviewed Jun 11, 2024
View reviewed changes
.gitignore Show resolved Hide resolved
Patterbear
Patterbear reviewed Jun 11, 2024
View reviewed changes
README.md Show resolved Hide resolved
Patterbear
Patterbear reviewed Jun 11, 2024
View reviewed changes
Copy link
Member

@Patterbear Patterbear left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for requesting a review.

Unfortunately, I'm not very experienced with actions, however, this does look good.

Left a few comments just asking some questions. I'll wait on the boss' approval before approving.

rothoma2
rothoma2 approved these changes Jun 12, 2024
View reviewed changes
Copy link
Contributor

@rothoma2 rothoma2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@lucifercr07 lucifercr07 force-pushed the lucifercr07/adding_linter_pre_commit_hook branch from 3003566 to 6649b78 Compare June 12, 2024 08:33
@lucifercr07 lucifercr07 force-pushed the lucifercr07/adding_linter_pre_commit_hook branch from 6649b78 to 1ed9c95 Compare June 12, 2024 08:34
@lucifercr07 lucifercr07 merged commit 84bcbc5 into main Jun 12, 2024
3 checks passed
@Patterbear Patterbear deleted the lucifercr07/adding_linter_pre_commit_hook branch June 26, 2024 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Patterbear Patterbear Patterbear left review comments

@rothoma2 rothoma2 rothoma2 approved these changes

Assignees

@lucifercr07 lucifercr07

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lucifercr07 @Patterbear @rothoma2