Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minidata API Spec cleanup #552

Merged
merged 2 commits into from
Nov 5, 2024
Merged

Minidata API Spec cleanup #552

merged 2 commits into from
Nov 5, 2024

Conversation

pydanny
Copy link
Collaborator

@pydanny pydanny commented Oct 27, 2024


name: Pull Request
about: Propose changes to the codebase
title: '[PR] Case and spelling corrections'
labels: 'documentation'
assignees: ''


Related Issue

#474

Proposed Changes

  • Capitalising and grammar corrections
  • State that setting .xtra is a one-way operation

Types of changes
What types of changes does your code introduce? Put an x in all the boxes that apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist
Go over all the following points, and put an x in all the boxes that apply:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I am aware that this is an nbdev project, and I have edited, cleaned, and synced the source notebooks instead of editing .py or .md files directly.

Copy link

gitnotebooks bot commented Oct 27, 2024

Found 2 changed notebooks. Review the changes at https://app.gitnotebooks.com/AnswerDotAI/fasthtml/pull/552

@pydanny pydanny changed the title Capitalising and grammar corrections Minidata API Spec cleanup Oct 27, 2024
@pydanny pydanny added the documentation Improvements or additions to documentation label Oct 27, 2024
@pydanny pydanny force-pushed the doc-Database-database branch from 3c07707 to 71cc43c Compare October 27, 2024 16:12
@jph00 jph00 self-requested a review November 3, 2024 04:35
Copy link
Contributor

@jph00 jph00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

from fastsql import *
db = database('postgres:...')

I don't think fastsql has a lowercase database().

@pydanny
Copy link
Collaborator Author

pydanny commented Nov 4, 2024

from fastsql import *
db = database('postgres:...')

I don't think fastsql has a lowercase database().

Oops! Updated!

@jph00 jph00 merged commit ef8f676 into main Nov 5, 2024
2 checks passed
@jph00 jph00 deleted the doc-Database-database branch November 5, 2024 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants