New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/harvester-swap #116

Merged

0xtekgrinder merged 12 commits into main from feat/harvester-swap

Sep 3, 2024

Merged

Feat/harvester-swap #116

fix: script updateFacets tests

GitHub Advanced Security / Slither succeeded Sep 3, 2024 in 6s

20 new alerts including 4 medium severity security vulnerabilities

New alerts in code changed by this pull request

Security Alerts:

4 medium
1 low

Other Alerts:

15 warnings

See annotations below for details.

View all branch alerts.

Annotations

Check warning on line 123 in contracts/helpers/BaseHarvester.sol

Code scanning / Slither

Divide before multiply Medium

BaseHarvester.harvest(address,uint256,bytes) performs a multiplication on the result of a division:
- amount = (amount * scale) / 1e9
- rebalancer.adjustYieldExposure(amount,increase,collateral,collatInfo.asset,(amount * (1e9 - maxSlippage)) / 1e9,extraData)

Check warning on line 123 in contracts/helpers/BaseHarvester.sol

Code scanning / Slither

Unused return Medium

BaseHarvester.harvest(address,uint256,bytes) ignores return value by (stablecoinsFromAsset) = TRANSMUTER.getIssuedByCollateral(collatInfo.asset)

Check warning on line 201 in contracts/helpers/BaseHarvester.sol

Code scanning / Slither

Unused return Medium

BaseHarvester._updateLimitExposuresYieldAsset(CollatParams) ignores return value by (xFeeMint,None) = TRANSMUTER.getCollateralMintFees(collatInfo.asset)

Check warning on line 201 in contracts/helpers/BaseHarvester.sol

Code scanning / Slither

Unused return Medium

BaseHarvester._updateLimitExposuresYieldAsset(CollatParams) ignores return value by (xFeeBurn,None) = TRANSMUTER.getCollateralBurnFees(collatInfo.asset)

Check warning on line 112 in contracts/helpers/BaseRebalancerFlashloan.sol

Code scanning / Slither

Dead-code Warning

BaseRebalancerFlashloan._swapToTokenIn(uint256,address,address,uint256,bytes) is never used and should be removed

Check warning on line 18 in contracts/helpers/HarvesterSwap.sol

Code scanning / Slither

Variable names too similar Warning

Variable HarvesterSwap.constructor(address,address,address,uint64,uint64,uint64,uint64,uint96).maxExposureYieldAsset is too similar to BaseHarvester._setCollateralData(address,address,uint64,uint64,uint64,uint64).minExposureYieldAsset

Check warning on line 18 in contracts/helpers/HarvesterSwap.sol

Code scanning / Slither

Variable names too similar Warning

Variable HarvesterSwap.constructor(address,address,address,uint64,uint64,uint64,uint64,uint96).maxExposureYieldAsset is too similar to BaseHarvester.setCollateralData(address,address,uint64,uint64,uint64,uint64).minExposureYieldAsset

Check warning on line 18 in contracts/helpers/HarvesterSwap.sol

Code scanning / Slither

Variable names too similar Warning

Variable HarvesterSwap.constructor(address,address,address,uint64,uint64,uint64,uint64,uint96).maxExposureYieldAsset is too similar to HarvesterSwap.constructor(address,address,address,uint64,uint64,uint64,uint64,uint96).minExposureYieldAsset

Check warning on line 18 in contracts/helpers/HarvesterSwap.sol

Code scanning / Slither

Variable names too similar Warning

Variable HarvesterSwap.constructor(address,address,address,uint64,uint64,uint64,uint64,uint96).maxExposureYieldAsset is too similar to BaseHarvester.constructor(address,address,address,uint64,uint64,uint64,uint64,uint96).minExposureYieldAsset

Check warning on line 18 in contracts/helpers/HarvesterVault.sol

Code scanning / Slither

Variable names too similar Warning

Variable HarvesterVault.constructor(address,address,uint64,uint64,uint64,uint64,uint96).maxExposureYieldAsset is too similar to BaseHarvester.setCollateralData(address,address,uint64,uint64,uint64,uint64).minExposureYieldAsset

Check warning on line 18 in contracts/helpers/HarvesterVault.sol

Code scanning / Slither

Variable names too similar Warning

Variable HarvesterVault.constructor(address,address,uint64,uint64,uint64,uint64,uint96).maxExposureYieldAsset is too similar to HarvesterVault.constructor(address,address,uint64,uint64,uint64,uint64,uint96).minExposureYieldAsset

Check warning on line 18 in contracts/helpers/HarvesterVault.sol

Code scanning / Slither

Variable names too similar Warning

Variable HarvesterVault.constructor(address,address,uint64,uint64,uint64,uint64,uint96).maxExposureYieldAsset is too similar to BaseHarvester.constructor(address,address,address,uint64,uint64,uint64,uint64,uint96).minExposureYieldAsset

Check warning on line 18 in contracts/helpers/HarvesterVault.sol

Code scanning / Slither

Variable names too similar Warning

Variable HarvesterVault.constructor(address,address,uint64,uint64,uint64,uint64,uint96).maxExposureYieldAsset is too similar to HarvesterVault.setCollateralData(address,uint64,uint64,uint64,uint64).minExposureYieldAsset

Check warning on line 18 in contracts/helpers/HarvesterVault.sol

Code scanning / Slither

Variable names too similar Warning

Variable HarvesterVault.constructor(address,address,uint64,uint64,uint64,uint64,uint96).maxExposureYieldAsset is too similar to BaseHarvester._setCollateralData(address,address,uint64,uint64,uint64,uint64).minExposureYieldAsset

Check warning on line 38 in contracts/helpers/HarvesterVault.sol

Code scanning / Slither

Variable names too similar Warning

Variable HarvesterVault.setCollateralData(address,uint64,uint64,uint64,uint64).maxExposureYieldAsset is too similar to BaseHarvester._setCollateralData(address,address,uint64,uint64,uint64,uint64).minExposureYieldAsset

Check warning on line 38 in contracts/helpers/HarvesterVault.sol

Code scanning / Slither

Variable names too similar Warning

Variable HarvesterVault.setCollateralData(address,uint64,uint64,uint64,uint64).maxExposureYieldAsset is too similar to BaseHarvester.constructor(address,address,address,uint64,uint64,uint64,uint64,uint96).minExposureYieldAsset

Check warning on line 38 in contracts/helpers/HarvesterVault.sol

Code scanning / Slither

Variable names too similar Warning

Variable HarvesterVault.setCollateralData(address,uint64,uint64,uint64,uint64).maxExposureYieldAsset is too similar to BaseHarvester.setCollateralData(address,address,uint64,uint64,uint64,uint64).minExposureYieldAsset

Check warning on line 38 in contracts/helpers/HarvesterVault.sol

Code scanning / Slither

Variable names too similar Warning

Variable HarvesterVault.setCollateralData(address,uint64,uint64,uint64,uint64).maxExposureYieldAsset is too similar to HarvesterVault.setCollateralData(address,uint64,uint64,uint64,uint64).minExposureYieldAsset

Check warning on line 38 in contracts/helpers/HarvesterVault.sol

Code scanning / Slither

Variable names too similar Warning

Variable HarvesterVault.setCollateralData(address,uint64,uint64,uint64,uint64).maxExposureYieldAsset is too similar to HarvesterVault.constructor(address,address,uint64,uint64,uint64,uint64,uint96).minExposureYieldAsset

Check notice on line 93 in contracts/helpers/RebalancerFlashloanSwap.sol

Code scanning / Slither

Block timestamp Low

RebalancerFlashloanSwap._swapToTokenIn(uint256,address,address,uint256,bytes) uses timestamp for comparisons
Dangerous comparisons:
- amountOut < (amount * (BPS - maxSlippage)) / BPS