TODO-s cleanup

AndyGura · Feb 3, 2024 · 4e64c04 · 4e64c04
1 parent 116d7b6
commit 4e64c04
Show file tree

Hide file tree

Showing 6 changed files with 2 additions and 23 deletions.
diff --git a/frontend/dist/gui/index.html b/frontend/dist/gui/index.html
@@ -11,6 +11,6 @@
 <style>.mat-typography{font-size:14px;font-weight:400;line-height:20px;font-family:Roboto,sans-serif;letter-spacing:.0178571429em}html,body{height:100%}body{margin:0;font-family:Roboto,Helvetica Neue,sans-serif}</style><link rel="stylesheet" href="styles.9650df2468906825.css" media="print" onload="this.media='all'"><noscript><link rel="stylesheet" href="styles.9650df2468906825.css"></noscript></head>
 <body class="mat-typography">
   <app-root></app-root>
-<script src="runtime.1713a2863c880bc2.js" type="module"></script><script src="polyfills.6ea95c2235df2b00.js" type="module"></script><script src="scripts.d5dc2919fc5b98cb.js" defer></script><script src="main.e8a5ff1a4a509e15.js" type="module"></script>
+<script src="runtime.1713a2863c880bc2.js" type="module"></script><script src="polyfills.6ea95c2235df2b00.js" type="module"></script><script src="scripts.d5dc2919fc5b98cb.js" defer></script><script src="main.d6de63c14ee1db84.js" type="module"></script>
 
 </body></html>
diff --git a/frontend/dist/gui/main.e8a5ff1a4a509e15.js → frontend/dist/gui/main.d6de63c14ee1db84.js b/frontend/dist/gui/main.e8a5ff1a4a509e15.js → frontend/dist/gui/main.d6de63c14ee1db84.js
diff --git a/frontend/src/app/components/editor/library/delegate.block-ui/delegate.block-ui.component.ts b/frontend/src/app/components/editor/library/delegate.block-ui/delegate.block-ui.component.ts
@@ -27,28 +27,12 @@ export class DelegateBlockUiComponent implements GuiComponentInterface {
         this.choiceDataCaches[this._resource.data.choice_index] = this._resource.data.data;
       }
     }
-    if (!this._resource) {
-      this.choiceResource = null;
-    } else {
-      this.choiceResource = {
-        id: this._resource.id + '/' + 'choice_index',
-        name: 'Block type choice',
-        data: this._resource.data.choice_index,
-        schema: {
-          block_class_mro: 'EnumBlock__IntegerBlock__DataBlock',
-          choices: [
-            // TODO finish EnumBlock and use another <app-editor here for correct file changes delta flow
-          ],
-        },
-      };
-    }
     this.updateChild();
   }
 
   @Input()
   resourceDescription: string = '';
 
-  choiceResource: Resource | null = null;
   childResource: Resource | null = null;
   choiceDataCaches: BlockData[] = [];
 

diff --git a/resources/eac/bitmaps.py b/resources/eac/bitmaps.py
@@ -55,7 +55,6 @@ class Fields(DeclarativeCompoundBlock.Fields):
                        {'description': 'Resource ID'})
         block_size = (IntegerBlock(length=3),
                       {'description': 'Bitmap block size 16+width\\*height/2 + trailing bytes length'})
-        # TODO ensure the value is even. At least for fonts
         width = (IntegerBlock(length=2),
                  {'description': 'Bitmap width in pixels. Has to be an even number (at least in the FFN font)'})
         height = (IntegerBlock(length=2),

diff --git a/resources/eac/palettes.py b/resources/eac/palettes.py
@@ -70,9 +70,6 @@ def read(self, buffer: [BufferedReader, BytesIO], ctx: ReadContext = None, name:
         return res
 
 
-# TODO 41 (0x29) 16 bit dos palette
-
-
 class PaletteReference(DeclarativeCompoundBlock):
     class Fields(DeclarativeCompoundBlock.Fields):
         resource_id = (IntegerBlock(length=1, required_value=0x7C),

diff --git a/serializers/archives.py b/serializers/archives.py
@@ -86,7 +86,6 @@ def serialize(self, data: dict, path: str, id=None, block=None, **kwargs):
     def deserialize(self, path: str, resource, quantize_new_palette=True, **kwargs) -> None:
         # FIXME not supported operations listed below:
         # does not support adding/removing bitmaps
-        # does not support changed image dimensions
         # does not support cases where 8-bitmaps use different palette (is it even possible?)
         # totally breaks car tail lights (TNFS)
         # tested with only 8bit images (TNFS shpi archives)