rounding pos components when used with getImageData

AndradaDevelopers · Aug 26, 2012 · 89611ae · 89611ae
1 parent 79a1029
commit 89611ae
Show file tree

Hide file tree

Showing 5 changed files with 6 additions and 24 deletions.
diff --git a/dist/kinetic-core.js b/dist/kinetic-core.js
@@ -560,15 +560,6 @@ Kinetic.Canvas.prototype = {
         this.setWidth(width);
         this.setHeight(height);
     },
-    /**
-     * strip away all functions that draw pixels onto the bitmap
-     * @name strip
-     * @methodOf Kinetic.Canvas.prototype
-     * @param {CanvasContext} context
-     */
-    strip: function() {
-        var context = this.context;
-    },
     /**
      * toDataURL
      */
@@ -3032,7 +3023,7 @@ Kinetic.Stage.prototype = {
          */
         for(var n = layers.length - 1; n >= 0; n--) {
             var layer = layers[n];
-            var p = layer.bufferCanvas.context.getImageData(pos.x, pos.y, 1, 1).data;
+            var p = layer.bufferCanvas.context.getImageData(Math.round(pos.x), Math.round(pos.y), 1, 1).data;
             // this indicates that a buffer pixel may have been found
             if(p[3] === 255) {
                 var colorKey = Kinetic.Type._rgbToHex(p[0], p[1], p[2]);
@@ -4090,7 +4081,7 @@ Kinetic.Shape.prototype = {
         var bufferCanvas = stage.bufferCanvas;
         bufferCanvas.clear();
         this._draw(bufferCanvas);
-        var p = bufferCanvas.context.getImageData(pos.x, pos.y, 1, 1).data;
+        var p = bufferCanvas.context.getImageData(Math.round(pos.x), Math.round(pos.y), 1, 1).data;
         return p[3] > 0;
     },
     __draw: function(canvas) {

diff --git a/dist/kinetic-core.min.js b/dist/kinetic-core.min.js
diff --git a/src/Shape.js b/src/Shape.js
@@ -332,7 +332,7 @@ Kinetic.Shape.prototype = {
         var bufferCanvas = stage.bufferCanvas;
         bufferCanvas.clear();
         this._draw(bufferCanvas);
-        var p = bufferCanvas.context.getImageData(pos.x, pos.y, 1, 1).data;
+        var p = bufferCanvas.context.getImageData(Math.round(pos.x), Math.round(pos.y), 1, 1).data;
         return p[3] > 0;
     },
     __draw: function(canvas) {

diff --git a/src/Stage.js b/src/Stage.js
@@ -364,7 +364,7 @@ Kinetic.Stage.prototype = {
          */
         for(var n = layers.length - 1; n >= 0; n--) {
             var layer = layers[n];
-            var p = layer.bufferCanvas.context.getImageData(pos.x, pos.y, 1, 1).data;
+            var p = layer.bufferCanvas.context.getImageData(Math.round(pos.x), Math.round(pos.y), 1, 1).data;
             // this indicates that a buffer pixel may have been found
             if(p[3] === 255) {
                 var colorKey = Kinetic.Type._rgbToHex(p[0], p[1], p[2]);

diff --git a/src/util/Canvas.js b/src/util/Canvas.js
@@ -84,15 +84,6 @@ Kinetic.Canvas.prototype = {
         this.setWidth(width);
         this.setHeight(height);
     },
-    /**
-     * strip away all functions that draw pixels onto the bitmap
-     * @name strip
-     * @methodOf Kinetic.Canvas.prototype
-     * @param {CanvasContext} context
-     */
-    strip: function() {
-        var context = this.context;
-    },
     /**
      * toDataURL
      */